Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2339703003: Fix webkit_tests by adding two more interfaces they expect. (Closed)

Created:
4 years, 3 months ago by Ben Goodger (Google)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix webkit_tests by adding two more interfaces they expect. TBR=rockot@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5a3bcc8be6b98f0084ad3cbf45045cfa4f848e3c Cr-Commit-Position: refs/heads/master@{#418600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339703003/1
4 years, 3 months ago (2016-09-14 17:19:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 17:21:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5a3bcc8be6b98f0084ad3cbf45045cfa4f848e3c Cr-Commit-Position: refs/heads/master@{#418600}
4 years, 3 months ago (2016-09-14 17:24:26 UTC) #7
msw
4 years, 3 months ago (2016-09-14 18:14:30 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2338163003/ by msw@chromium.org.

The reason for reverting is: Reverting this and
https://codereview.chromium.org/2259903002
I'll post more details on the other CL.

Powered by Google App Engine
This is Rietveld 408576698