Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2339703002: ash: Adjust ascii art comment to avoid looking like multiline comment (Closed)

Created:
4 years, 3 months ago by Daniel Erat
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

ash: Adjust ascii art comment to avoid looking like multiline comment When building ash_unittests under "simple chrome": cros chrome-sdk gcc is used. The comment in WindowModalityControllerTest looks like a multline comment, triggering -Werror=comment. This CL adjusts the ascii art to avoid triggering that error. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" Review-Url: https://codereview.chromium.org/2160603002 Cr-Commit-Position: refs/heads/master@{#406024} (cherry picked from commit 9f937f5b6731f71d199d00c34b895e10661bc13e) Committed: https://chromium.googlesource.com/chromium/src/+/7128fa473b1230227e5363ba0d6d3c70477accc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ash/wm/window_modality_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Daniel Erat
4 years, 3 months ago (2016-09-13 21:24:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7128fa473b1230227e5363ba0d6d3c70477accc4.

Powered by Google App Engine
This is Rietveld 408576698