Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2160603002: ash: Adjust ascii art comment to avoid looking like multiline comment (Closed)

Created:
4 years, 5 months ago by robert.bradford
Modified:
4 years, 5 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Adjust ascii art comment to avoid looking like multiline comment When building ash_unittests under "simple chrome": cros chrome-sdk gcc is used. The comment in WindowModalityControllerTest looks like a multline comment, triggering -Werror=comment. This CL adjusts the ascii art to avoid triggering that error. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" Committed: https://crrev.com/9f937f5b6731f71d199d00c34b895e10661bc13e Cr-Commit-Position: refs/heads/master@{#406024}

Patch Set 1 : ash: Adjust ascii art comment to avoid looking like multiline comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ash/wm/window_modality_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
robert.bradford
Hi Daniel, could you review?
4 years, 5 months ago (2016-07-18 14:49:36 UTC) #4
Daniel Erat
lgtm
4 years, 5 months ago (2016-07-18 15:24:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160603002/20001
4 years, 5 months ago (2016-07-18 16:18:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-18 17:31:02 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 17:32:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f937f5b6731f71d199d00c34b895e10661bc13e
Cr-Commit-Position: refs/heads/master@{#406024}

Powered by Google App Engine
This is Rietveld 408576698