Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2339663002: [Mac] Fullscreen Toolbar Bar Visibility Edge Cases (Closed)

Created:
4 years, 3 months ago by spqchan
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Mac] Fullscreen Toolbar Bar Visibility Edge Cases Fixed edge case for the toolbar visibility locks. BUG=641751, 641749 Review-Url: https://codereview.chromium.org/2296903002 Cr-Commit-Position: refs/heads/master@{#417799} (cherry picked from commit a431d992f7c15f070be18e6a51419c11445a785a) Committed: https://chromium.googlesource.com/chromium/src/+/1cbc6cd466a75352f240c1308c96ebccb2ec4dae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -80 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 5 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.mm View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h View 4 chunks +34 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm View 13 chunks +73 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
4 years, 3 months ago (2016-09-13 20:14:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1cbc6cd466a75352f240c1308c96ebccb2ec4dae.

Powered by Google App Engine
This is Rietveld 408576698