Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3626)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2339663002: [Mac] Fullscreen Toolbar Bar Visibility Edge Cases (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 3edc977891d90231a0aa4617413742d6f38b1c21..9ba6b820d09db8e0b2992cf2a5f82d2cb917b83d 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1877,13 +1877,15 @@ willAnimateFromState:(BookmarkBar::State)oldState
(ExclusiveAccessContext::TabFullscreenState)state {
DCHECK([self isInAnyFullscreenMode]);
if (state == ExclusiveAccessContext::STATE_ENTER_TAB_FULLSCREEN) {
- [self adjustUIForSlidingFullscreenStyle:fullscreen_mac::OMNIBOX_TABS_NONE];
+ [self adjustUIForSlidingFullscreenStyle:FullscreenSlidingStyle::
+ OMNIBOX_TABS_NONE];
return;
}
[self adjustUIForSlidingFullscreenStyle:
- shouldShowFullscreenToolbar_ ? fullscreen_mac::OMNIBOX_TABS_PRESENT
- : fullscreen_mac::OMNIBOX_TABS_HIDDEN];
+ shouldShowFullscreenToolbar_
+ ? FullscreenSlidingStyle::OMNIBOX_TABS_PRESENT
+ : FullscreenSlidingStyle::OMNIBOX_TABS_HIDDEN];
}
- (void)updateFullscreenExitBubble {
@@ -1907,8 +1909,9 @@ willAnimateFromState:(BookmarkBar::State)oldState
shouldShowFullscreenToolbar_ = visible;
[self adjustUIForSlidingFullscreenStyle:
- shouldShowFullscreenToolbar_ ? fullscreen_mac::OMNIBOX_TABS_PRESENT
- : fullscreen_mac::OMNIBOX_TABS_HIDDEN];
+ shouldShowFullscreenToolbar_
+ ? FullscreenSlidingStyle::OMNIBOX_TABS_PRESENT
+ : FullscreenSlidingStyle::OMNIBOX_TABS_HIDDEN];
}
- (BOOL)isInAnyFullscreenMode {
@@ -1991,7 +1994,7 @@ willAnimateFromState:(BookmarkBar::State)oldState
// If enabled, show the overlay if necessary (and if the fullscreen
// toolbar is hidden).
if (barVisibilityUpdatesEnabled_) {
- [fullscreenToolbarController_ ensureOverlayShownWithAnimation:animate];
+ [fullscreenToolbarController_ lockBarVisibilityWithAnimation:animate];
}
}
}
@@ -2004,7 +2007,7 @@ willAnimateFromState:(BookmarkBar::State)oldState
// toolbar is hidden).
if (barVisibilityUpdatesEnabled_ &&
![barVisibilityLocks_ count]) {
- [fullscreenToolbarController_ ensureOverlayHiddenWithAnimation:animate];
+ [fullscreenToolbarController_ releaseBarVisibilityWithAnimation:animate];
}
}
}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698