Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2339563004: Move NSWindow.allowsAutomaticWindowTabbing forward declaration to the right place. (Closed)

Created:
4 years, 3 months ago by Sidney San Martín
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move NSWindow.allowsAutomaticWindowTabbing forward declaration to the right place. When I added it in this CL: https://codereview.chromium.org/2325313002/ …it worked for 10.11 (coincidentally) but not for the 10.12 SDK. BUG=642155 Committed: https://crrev.com/b9c29dbbb6aea2261a452b31725ecdd97dce5c43 Cr-Commit-Position: refs/heads/master@{#418466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M base/mac/sdk_forward_declarations.h View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sidney San Martín
4 years, 3 months ago (2016-09-14 01:22:54 UTC) #3
Nico
lgtm
4 years, 3 months ago (2016-09-14 01:23:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339563004/1
4 years, 3 months ago (2016-09-14 01:25:32 UTC) #6
Nico
Is this the only thing needed to build with the 10.12 sdk? Did you try ...
4 years, 3 months ago (2016-09-14 01:27:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 02:57:27 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b9c29dbbb6aea2261a452b31725ecdd97dce5c43 Cr-Commit-Position: refs/heads/master@{#418466}
4 years, 3 months ago (2016-09-14 03:00:13 UTC) #11
Sidney San Martín
4 years, 3 months ago (2016-09-14 06:07:06 UTC) #12
Message was sent while issue was closed.
On 2016/09/14 01:27:08, Nico wrote:
> Is this the only thing needed to build with the 10.12 sdk? Did you try
building
> 'all'?

Building 'all' was a success.

Powered by Google App Engine
This is Rietveld 408576698