Opt out of macOS Sierra automatic window tabbing

Opt out of macOS Sierra automatic window tabbing

…for now.

BUG=642155
Committed: https://crrev.com/5788338a8a54e230ef868e66c4ab309bb76dfd65
Cr-Commit-Position: refs/heads/master@{#417948}

[Sidney San Martín, 2016-09-10 00:15:32]

Description was changed from

==========
Opt out of macOS Sierra automatic window tabbing

BUG=642155
==========

to

==========
Opt out of macOS Sierra automatic window tabbing

…for now.

BUG=642155
==========

[Sidney San Martín, 2016-09-10 00:15:33]

sdy@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-09-12 14:13:59]

lgtm

https://codereview.chromium.org/2325313002/diff/1/base/mac/sdk_forward_declar...
File base/mac/sdk_forward_declarations.h (right):

https://codereview.chromium.org/2325313002/diff/1/base/mac/sdk_forward_declar...
base/mac/sdk_forward_declarations.h:42: @property(class) BOOL
allowsAutomaticWindowTabbing;
TIL

https://codereview.chromium.org/2325313002/diff/1/chrome/browser/app_controll...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/2325313002/diff/1/chrome/browser/app_controll...
chrome/browser/app_controller_mac.mm:412: if ([NSWindow
respondsToSelector:@selector(allowsAutomaticWindowTabbing)]) {
is checking for `setAllowsAutomaticWindowTabbing:` more correct since that's
what you're calling? (optional comment, doesn't matter in practice)

[Sidney San Martín, 2016-09-12 15:07:12]

The CQ bit was checked by sdy@chromium.org

[Sidney San Martín, 2016-09-12 15:07:25]

https://codereview.chromium.org/2325313002/diff/1/chrome/browser/app_controll...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/2325313002/diff/1/chrome/browser/app_controll...
chrome/browser/app_controller_mac.mm:412: if ([NSWindow
respondsToSelector:@selector(allowsAutomaticWindowTabbing)]) {
On 2016/09/12 14:13:58, Nico wrote:
> is checking for `setAllowsAutomaticWindowTabbing:` more correct since that's
> what you're calling? (optional comment, doesn't matter in practice)

You are technically correct — the best kind of correct.

I thought about this before I submitted. I kept it because even though
`setAllowsAutomaticWindowTabbing:` is the actual method, I feel like
`allowsAutomaticWindowTabbing` more clearly expresses our intent to make sure
the property exists at all.

[commit-bot: I haz the power, 2016-09-12 15:07:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 16:01:07]

Description was changed from

==========
Opt out of macOS Sierra automatic window tabbing

…for now.

BUG=642155
==========

to

==========
Opt out of macOS Sierra automatic window tabbing

…for now.

BUG=642155
==========

[commit-bot: I haz the power, 2016-09-12 16:01:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-12 16:02:39]

Description was changed from

==========
Opt out of macOS Sierra automatic window tabbing

…for now.

BUG=642155
==========

to

==========
Opt out of macOS Sierra automatic window tabbing

…for now.

BUG=642155

Committed: https://crrev.com/5788338a8a54e230ef868e66c4ab309bb76dfd65
Cr-Commit-Position: refs/heads/master@{#417948}
==========

[commit-bot: I haz the power, 2016-09-12 16:02:40]

Patchset 1 (id:??) landed as
https://crrev.com/5788338a8a54e230ef868e66c4ab309bb76dfd65
Cr-Commit-Position: refs/heads/master@{#417948}

[erikchen, 2016-09-12 16:52:08]

On 2016/09/12 16:02:40, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/5788338a8a54e230ef868e66c4ab309bb76dfd65
> Cr-Commit-Position: refs/heads/master@{#417948}

Don't you need to do this on all NSWindows created by Chrome? If you just wanted
the main browser window, wouldn't FramedBrowserWindow be the right place for
this?

[Sidney San Martín, 2016-09-12 16:59:15]

On 2016/09/12 16:52:08, erikchen wrote:
> On 2016/09/12 16:02:40, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/5788338a8a54e230ef868e66c4ab309bb76dfd65
> > Cr-Commit-Position: refs/heads/master@{#417948}
> 
> Don't you need to do this on all NSWindows created by Chrome? If you just
wanted
> the main browser window, wouldn't FramedBrowserWindow be the right place for
> this?

This is a class property which applies to the application as a whole. I don't
think we need to do anything window specific.