Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2339463002: Increase maximum size of the HPACK decoder dynamic table to 64 kB. (Closed)

Created:
4 years, 3 months ago by Bence
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Increase maximum size of the HPACK decoder dynamic table to 64 kB. * Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on each HTTP/2 connection. * Immediately notify HpackDecoder about the change so that it allows the encoder to update the dynamic table size up to this limit. It is safe to do so before receiving the SETTINGS ACK, because the new limit is larger than the default 4 kB. In fact, a server following RFC 7540 Section 6.5.3 word-by-word might already use the larger limit before sending an ACK. BUG=642784 Committed: https://crrev.com/b3cafaaea4c3c0c1cf553d8ec9999f83a8c1c7f4 Review-Url: https://codereview.chromium.org/2300683002 Cr-Original-Commit-Position: refs/heads/master@{#415718} Cr-Commit-Position: refs/heads/master@{#416284} (cherry picked from commit b3cafaaea4c3c0c1cf553d8ec9999f83a8c1c7f4) Committed: https://chromium.googlesource.com/chromium/src/+/13d05e85b2565345c84d071c83ede52eefa60c81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -23 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java View 4 chunks +30 lines, -20 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/hpack/hpack_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Bence
4 years, 3 months ago (2016-09-13 13:46:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13d05e85b2565345c84d071c83ede52eefa60c81.

Powered by Google App Engine
This is Rietveld 408576698