Increase maximum size of the HPACK decoder dynamic table to 64 kB.

Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784
Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Committed: https://crrev.com/b3cafaaea4c3c0c1cf553d8ec9999f83a8c1c7f4
Cr-Original-Commit-Position: refs/heads/master@{#415718}
Cr-Commit-Position: refs/heads/master@{#416284}

[Bence, 2016-08-31 17:00:41]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:01:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 18:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 18:20:59]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-08-31 18:25:11]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-08-31 18:25:12]

Ryan: PTAL.

[Ryan Hamilton, 2016-08-31 18:37:15]

lgtm

[Bence, 2016-08-31 19:10:18]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:10:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:16:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 19:19:25]

Description was changed from

==========
Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784
==========

to

==========
Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784

Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Cr-Commit-Position: refs/heads/master@{#415718}
==========

[commit-bot: I haz the power, 2016-08-31 19:19:26]

Patchset 1 (id:??) landed as
https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Cr-Commit-Position: refs/heads/master@{#415718}

[mdjones, 2016-08-31 20:10:52]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2302573002/ by mdjones@chromium.org.

The reason for reverting is: Suspected patch causing Android Cronet Builder and
other bots to fail BidirectionalStreamTest#testSimpleGet. Will re-land if not..

[xunjieli, 2016-08-31 20:29:07]

Bence, looks like you might need to update the expectation in
components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java,
which hardcodes how many bytes will be received over the stream.

Let me know if I can help.

C  181.719s Main  [FAIL] org.chromium.net.BidirectionalStreamTest#testSimpleGet:
C  181.719s Main  java.lang.Throwable: CronetTestBase#runTest failed.
C  181.719s Main  	at
org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:147)
C  181.719s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  181.719s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  181.719s Main  	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  181.719s Main  	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  181.719s Main  Caused by: junit.framework.AssertionFailedError: expected:<27>
but was:<31>
C  181.719s Main  	at
org.chromium.net.CronetTestBase.assertResponseEquals(CronetTestBase.java:163)
C  181.719s Main  	at
org.chromium.net.BidirectionalStreamTest.testSimpleGet(BidirectionalStreamTest.java:182)
C  181.719s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  181.719s Main  	at
org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:137)
C  181.719s Main  	... 9 more
C  181.719s Main  
C  181.719s Main  [FAIL]
org.chromium.net.BidirectionalStreamTest#testSimpleHead:
C  181.719s Main  java.lang.Throwable: CronetTestBase#runTest failed.
C  181.719s Main  	at
org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:147)
C  181.719s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  181.719s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  181.719s Main  	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  181.719s Main  	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  181.720s Main  Caused by: junit.framework.AssertionFailedError: expected:<28>
but was:<32>
C  181.720s Main  	at
org.chromium.net.CronetTestBase.assertResponseEquals(CronetTestBase.java:163)
C  181.720s Main  	at
org.chromium.net.BidirectionalStreamTest.testSimpleHead(BidirectionalStreamTest.java:205)
C  181.720s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  181.720s Main  	at
org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:137)
C  181.720s Main  	... 9 more

[xunjieli, 2016-08-31 20:29:33]

Description was changed from

==========
Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784

Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Cr-Commit-Position: refs/heads/master@{#415718}
==========

to

==========
Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784

Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Cr-Commit-Position: refs/heads/master@{#415718}
==========

[Ryan Hamilton, 2016-08-31 20:34:15]

On 2016/08/31 20:10:52, mdjones wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2302573002/ by mailto:mdjones@chromium.org.
> 
> The reason for reverting is: Suspected patch causing Android Cronet Builder
and
> other bots to fail BidirectionalStreamTest#testSimpleGet. Will re-land if
not..

I know I sound like a broken record, but we *really* need to get this bot into
the CQ so that we're not flying blind.

[Bence, 2016-09-01 19:45:59]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 19:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2016-09-01 19:46:52]

bnc@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Bence, 2016-09-01 19:46:52]

Helen: PTAL.  Cronet Android tests pass locally.

[xunjieli, 2016-09-01 19:55:23]

cronet test lgtm.

https://codereview.chromium.org/2300683002/diff/20001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
(right):

https://codereview.chromium.org/2300683002/diff/20001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java:1080:
// asserts in TestBidirectionalCallback.
Could you add a brief comment here on why we use 27 instead of 31? This is
mainly for future reference so it's easier to understand when reading the code.

[Bence, 2016-09-02 15:45:04]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-09-02 15:45:05]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org,
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2300683002/#ps40001
(title: "Add comment in Cronet tests.")

[commit-bot: I haz the power, 2016-09-02 15:45:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:00:13]

Description was changed from

==========
Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784

Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Cr-Commit-Position: refs/heads/master@{#415718}
==========

to

==========
Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784

Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Cr-Commit-Position: refs/heads/master@{#415718}
==========

[commit-bot: I haz the power, 2016-09-02 17:00:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 17:03:35]

Description was changed from

==========
Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784

Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Cr-Commit-Position: refs/heads/master@{#415718}
==========

to

==========
Increase maximum size of the HPACK decoder dynamic table to 64 kB.

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784

Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Committed: https://crrev.com/b3cafaaea4c3c0c1cf553d8ec9999f83a8c1c7f4
Cr-Original-Commit-Position: refs/heads/master@{#415718}
Cr-Commit-Position: refs/heads/master@{#416284}
==========

[commit-bot: I haz the power, 2016-09-02 17:03:36]

Patchset 3 (id:??) landed as
https://crrev.com/b3cafaaea4c3c0c1cf553d8ec9999f83a8c1c7f4
Cr-Commit-Position: refs/heads/master@{#416284}