Roll recipe DEPS

Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/90d0bfae4eded779c7415d0ec116de3da37b8ae6

[rmistry, 2016-09-14 11:47:56]

Description was changed from

==========
Roll recipe DEPS

BUG=skia:5749
==========

to

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
==========

[rmistry, 2016-09-14 11:48:40]

Description was changed from

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
==========

to

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003

NOTRY=true
==========

[rmistry, 2016-09-14 11:48:45]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 11:48:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 11:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 11:49:59]

Dry run: This issue passed the CQ dry run.

[rmistry, 2016-09-14 11:50:59]

Description was changed from

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003

NOTRY=true
==========

to

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003

COMMIT=false
==========

[rmistry, 2016-09-14 11:52:50]

rmistry@google.com changed reviewers:
+ borenet@google.com

[rmistry, 2016-09-14 11:52:51]

I updated the hashes in recipe.cfg to pick up a fix in depot_tools but "python
infra/bots/recipes.py simulation test" is failing with:

Traceback (most recent call last):
  File "/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py", line
567, in <module>
    ret = main()
  File "/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py", line
519, in main
    deps_path=args.deps_path, overrides=args.project_override)
  File
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
line 619, in create
    package_deps._root_package =
package_deps._create_package(RootRepoSpec(proto_file))
  File
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
line 626, in _create_package
    return self._create_from_spec(repo_spec, package_spec)
  File
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
line 647, in _create_from_spec
    deps[dep] = self._create_package(dep_repo)
  File
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
line 626, in _create_package
    return self._create_from_spec(repo_spec, package_spec)
  File
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
line 641, in _create_from_spec
    project_id, (repo_spec, self._packages[project_id].repo_spec))
recipe_engine.package.InconsistentDependencyGraphError


Any ideas?

[borenet, 2016-09-14 11:55:08]

On 2016/09/14 11:52:51, rmistry wrote:
> I updated the hashes in recipe.cfg to pick up a fix in depot_tools but "python
> infra/bots/recipes.py simulation test" is failing with:
> 
> Traceback (most recent call last):
>   File "/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py",
line
> 567, in <module>
>     ret = main()
>   File "/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py",
line
> 519, in main
>     deps_path=args.deps_path, overrides=args.project_override)
>   File
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> line 619, in create
>     package_deps._root_package =
> package_deps._create_package(RootRepoSpec(proto_file))
>   File
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> line 626, in _create_package
>     return self._create_from_spec(repo_spec, package_spec)
>   File
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> line 647, in _create_from_spec
>     deps[dep] = self._create_package(dep_repo)
>   File
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> line 626, in _create_package
>     return self._create_from_spec(repo_spec, package_spec)
>   File
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> line 641, in _create_from_spec
>     project_id, (repo_spec, self._packages[project_id].repo_spec))
> recipe_engine.package.InconsistentDependencyGraphError
> 
> 
> Any ideas?

Two different repos have the same repo as a dependency but want different
revisions of it.  The easiest way to do this is to roll build.git to whatever
revision you want, then look in its recipes.cfg file to get the other two
hashes.

[rmistry, 2016-09-14 12:03:40]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 12:03:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmistry, 2016-09-14 12:07:21]

On 2016/09/14 11:55:08, borenet wrote:
> On 2016/09/14 11:52:51, rmistry wrote:
> > I updated the hashes in recipe.cfg to pick up a fix in depot_tools but
"python
> > infra/bots/recipes.py simulation test" is failing with:
> > 
> > Traceback (most recent call last):
> >   File "/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py",
> line
> > 567, in <module>
> >     ret = main()
> >   File "/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py",
> line
> > 519, in main
> >     deps_path=args.deps_path, overrides=args.project_override)
> >   File
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > line 619, in create
> >     package_deps._root_package =
> > package_deps._create_package(RootRepoSpec(proto_file))
> >   File
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > line 626, in _create_package
> >     return self._create_from_spec(repo_spec, package_spec)
> >   File
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > line 647, in _create_from_spec
> >     deps[dep] = self._create_package(dep_repo)
> >   File
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > line 626, in _create_package
> >     return self._create_from_spec(repo_spec, package_spec)
> >   File
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > line 641, in _create_from_spec
> >     project_id, (repo_spec, self._packages[project_id].repo_spec))
> > recipe_engine.package.InconsistentDependencyGraphError
> > 
> > 
> > Any ideas?
> 
> Two different repos have the same repo as a dependency but want different
> revisions of it.  The easiest way to do this is to roll build.git to whatever
> revision you want, then look in its recipes.cfg file to get the other two
> hashes.

Thanks, fixed it.
Looks like there are expectations changes. Robbie has been refactoring some
things in bot_update.
PTAL.

[borenet, 2016-09-14 12:19:16]

On 2016/09/14 12:07:21, rmistry wrote:
> On 2016/09/14 11:55:08, borenet wrote:
> > On 2016/09/14 11:52:51, rmistry wrote:
> > > I updated the hashes in recipe.cfg to pick up a fix in depot_tools but
> "python
> > > infra/bots/recipes.py simulation test" is failing with:
> > > 
> > > Traceback (most recent call last):
> > >   File
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py",
> > line
> > > 567, in <module>
> > >     ret = main()
> > >   File
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py",
> > line
> > > 519, in main
> > >     deps_path=args.deps_path, overrides=args.project_override)
> > >   File
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > line 619, in create
> > >     package_deps._root_package =
> > > package_deps._create_package(RootRepoSpec(proto_file))
> > >   File
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > line 626, in _create_package
> > >     return self._create_from_spec(repo_spec, package_spec)
> > >   File
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > line 647, in _create_from_spec
> > >     deps[dep] = self._create_package(dep_repo)
> > >   File
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > line 626, in _create_package
> > >     return self._create_from_spec(repo_spec, package_spec)
> > >   File
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > line 641, in _create_from_spec
> > >     project_id, (repo_spec, self._packages[project_id].repo_spec))
> > > recipe_engine.package.InconsistentDependencyGraphError
> > > 
> > > 
> > > Any ideas?
> > 
> > Two different repos have the same repo as a dependency but want different
> > revisions of it.  The easiest way to do this is to roll build.git to
whatever
> > revision you want, then look in its recipes.cfg file to get the other two
> > hashes.
> 
> Thanks, fixed it.
> Looks like there are expectations changes. Robbie has been refactoring some
> things in bot_update.
> PTAL.

I don't think this will work.  Now gclient is looking for .DEPS.git, which does
not exist in Skia.  Is there a fallback to use plain DEPS?

[commit-bot: I haz the power, 2016-09-14 12:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 12:48:47]

Dry run: This issue passed the CQ dry run.

[rmistry, 2016-09-14 13:11:53]

On 2016/09/14 12:19:16, borenet wrote:
> On 2016/09/14 12:07:21, rmistry wrote:
> > On 2016/09/14 11:55:08, borenet wrote:
> > > On 2016/09/14 11:52:51, rmistry wrote:
> > > > I updated the hashes in recipe.cfg to pick up a fix in depot_tools but
> > "python
> > > > infra/bots/recipes.py simulation test" is failing with:
> > > > 
> > > > Traceback (most recent call last):
> > > >   File
> "/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py",
> > > line
> > > > 567, in <module>
> > > >     ret = main()
> > > >   File
> "/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipes.py",
> > > line
> > > > 519, in main
> > > >     deps_path=args.deps_path, overrides=args.project_override)
> > > >   File
> > > >
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > > line 619, in create
> > > >     package_deps._root_package =
> > > > package_deps._create_package(RootRepoSpec(proto_file))
> > > >   File
> > > >
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > > line 626, in _create_package
> > > >     return self._create_from_spec(repo_spec, package_spec)
> > > >   File
> > > >
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > > line 647, in _create_from_spec
> > > >     deps[dep] = self._create_package(dep_repo)
> > > >   File
> > > >
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > > line 626, in _create_package
> > > >     return self._create_from_spec(repo_spec, package_spec)
> > > >   File
> > > >
> > >
> >
>
"/repos/skia/skia/infra/bots/.recipe_deps/recipe_engine/recipe_engine/package.py",
> > > > line 641, in _create_from_spec
> > > >     project_id, (repo_spec, self._packages[project_id].repo_spec))
> > > > recipe_engine.package.InconsistentDependencyGraphError
> > > > 
> > > > 
> > > > Any ideas?
> > > 
> > > Two different repos have the same repo as a dependency but want different
> > > revisions of it.  The easiest way to do this is to roll build.git to
> whatever
> > > revision you want, then look in its recipes.cfg file to get the other two
> > > hashes.
> > 
> > Thanks, fixed it.
> > Looks like there are expectations changes. Robbie has been refactoring some
> > things in bot_update.
> > PTAL.
> 
> I don't think this will work.  Now gclient is looking for .DEPS.git, which
does
> not exist in Skia.  Is there a fallback to use plain DEPS?

Looks like the trybots on this worked (I think). Eg:
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
and in gclient sync it said .DEPS.git
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
no idea how it thinks it found .DEPS.git

I traced it to changing GIT_MODE to True in
https://codereview.chromium.org/2270083004/
Looks like swarmbucket_wrapper.py also uses GIT_MODE=True:
https://skia.googlesource.com/skia/+/master/infra/bots/recipes/swarmbucket_wr...

I tried doing cfg_kwargs['GIT_MODE'] = False in core/api.py. I thought that
would change all expectations back but none changed. Any idea why?

[borenet, 2016-09-14 13:49:15]

> Looks like the trybots on this worked (I think). Eg:
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> and in gclient sync it said .DEPS.git
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> no idea how it thinks it found .DEPS.git
> 
> I traced it to changing GIT_MODE to True in
> https://codereview.chromium.org/2270083004/
> Looks like swarmbucket_wrapper.py also uses GIT_MODE=True:
>
https://skia.googlesource.com/skia/+/master/infra/bots/recipes/swarmbucket_wr...
> 
> I tried doing cfg_kwargs['GIT_MODE'] = False in core/api.py. I thought that
> would change all expectations back but none changed. Any idea why?

No clue. I worry that the trybots succeeded by coincidence, or that this will
work for existing checkouts but not new ones or something like that. I think we
need to talk to whoever made the change upstream.

[rmistry, 2016-09-14 16:46:11]

Description was changed from

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003

COMMIT=false
==========

to

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003

COMMIT=false
NOTRY=true
==========

[rmistry, 2016-09-14 16:46:17]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 16:46:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 16:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 16:47:36]

Dry run: This issue passed the CQ dry run.

[rmistry, 2016-09-14 16:50:53]

Description was changed from

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003

COMMIT=false
NOTRY=true
==========

to

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003

COMMIT=false
==========

[rmistry, 2016-09-14 16:51:02]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 16:51:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gacon, 2016-09-14 17:00:38]

gaconyeuemnhieu@gmail.com changed reviewers:
+ gaconyeuemnhieu@gmail.com

[rmistry, 2016-09-14 17:14:02]

rmistry@google.com changed reviewers:
- gaconyeuemnhieu@gmail.com

[rmistry, 2016-09-14 17:15:04]

On 2016/09/14 13:49:15, borenet wrote:
> > Looks like the trybots on this worked (I think). Eg:
> >
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> > and in gclient sync it said .DEPS.git
> >
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> > no idea how it thinks it found .DEPS.git
> > 
> > I traced it to changing GIT_MODE to True in
> > https://codereview.chromium.org/2270083004/
> > Looks like swarmbucket_wrapper.py also uses GIT_MODE=True:
> >
>
https://skia.googlesource.com/skia/+/master/infra/bots/recipes/swarmbucket_wr...
> > 
> > I tried doing cfg_kwargs['GIT_MODE'] = False in core/api.py. I thought that
> > would change all expectations back but none changed. Any idea why?
> 
> No clue. I worry that the trybots succeeded by coincidence, or that this will
> work for existing checkouts but not new ones or something like that. I think
we
> need to talk to whoever made the change upstream.

So looks like GIT_MODE was completely removed in
https://codereview.chromium.org/2286793003 so there is no way to go back.
I suspect under the hood if .DEPS.git is not found then it uses DEPS but I am
going to try to confirm that.

[borenet, 2016-09-14 17:18:15]

On 2016/09/14 17:15:04, rmistry wrote:
> On 2016/09/14 13:49:15, borenet wrote:
> > > Looks like the trybots on this worked (I think). Eg:
> > >
> >
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> > > and in gclient sync it said .DEPS.git
> > >
> >
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> > > no idea how it thinks it found .DEPS.git
> > > 
> > > I traced it to changing GIT_MODE to True in
> > > https://codereview.chromium.org/2270083004/
> > > Looks like swarmbucket_wrapper.py also uses GIT_MODE=True:
> > >
> >
>
https://skia.googlesource.com/skia/+/master/infra/bots/recipes/swarmbucket_wr...
> > > 
> > > I tried doing cfg_kwargs['GIT_MODE'] = False in core/api.py. I thought
that
> > > would change all expectations back but none changed. Any idea why?
> > 
> > No clue. I worry that the trybots succeeded by coincidence, or that this
will
> > work for existing checkouts but not new ones or something like that. I think
> we
> > need to talk to whoever made the change upstream.
> 
> So looks like GIT_MODE was completely removed in
> https://codereview.chromium.org/2286793003 so there is no way to go back.
> I suspect under the hood if .DEPS.git is not found then it uses DEPS but I am
> going to try to confirm that.

Ok, LGTM to get this unblocked but we should verify that there's a fallback. 
I'm also not familiar with some of the new flags...

[rmistry, 2016-09-14 17:31:42]

On 2016/09/14 17:18:15, borenet wrote:
> On 2016/09/14 17:15:04, rmistry wrote:
> > On 2016/09/14 13:49:15, borenet wrote:
> > > > Looks like the trybots on this worked (I think). Eg:
> > > >
> > >
> >
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> > > > and in gclient sync it said .DEPS.git
> > > >
> > >
> >
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> > > > no idea how it thinks it found .DEPS.git
> > > > 
> > > > I traced it to changing GIT_MODE to True in
> > > > https://codereview.chromium.org/2270083004/
> > > > Looks like swarmbucket_wrapper.py also uses GIT_MODE=True:
> > > >
> > >
> >
>
https://skia.googlesource.com/skia/+/master/infra/bots/recipes/swarmbucket_wr...
> > > > 
> > > > I tried doing cfg_kwargs['GIT_MODE'] = False in core/api.py. I thought
> that
> > > > would change all expectations back but none changed. Any idea why?
> > > 
> > > No clue. I worry that the trybots succeeded by coincidence, or that this
> will
> > > work for existing checkouts but not new ones or something like that. I
think
> > we
> > > need to talk to whoever made the change upstream.
> > 
> > So looks like GIT_MODE was completely removed in
> > https://codereview.chromium.org/2286793003 so there is no way to go back.
> > I suspect under the hood if .DEPS.git is not found then it uses DEPS but I
am
> > going to try to confirm that.
> 
> Ok, LGTM to get this unblocked but we should verify that there's a fallback. 
> I'm also not familiar with some of the new flags...

Chromium also only has a DEPS
(https://chromium.googlesource.com/chromium/src/+/master/DEPS) and no .DEPS.git.

I asked Pawel, he said not to worry about it since it works for Chromium. Aaron
is OOO. Asked Robbie as well but have not heard back.

I have no idea about the new flags too. Since this change was done on other
projects, hopefully it does not break any existing behavior.

I will aim to submit this late today.

[rmistry, 2016-09-14 18:02:41]

On 2016/09/14 17:31:42, rmistry wrote:
> On 2016/09/14 17:18:15, borenet wrote:
> > On 2016/09/14 17:15:04, rmistry wrote:
> > > On 2016/09/14 13:49:15, borenet wrote:
> > > > > Looks like the trybots on this worked (I think). Eg:
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> > > > > and in gclient sync it said .DEPS.git
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_...
> > > > > no idea how it thinks it found .DEPS.git
> > > > > 
> > > > > I traced it to changing GIT_MODE to True in
> > > > > https://codereview.chromium.org/2270083004/
> > > > > Looks like swarmbucket_wrapper.py also uses GIT_MODE=True:
> > > > >
> > > >
> > >
> >
>
https://skia.googlesource.com/skia/+/master/infra/bots/recipes/swarmbucket_wr...
> > > > > 
> > > > > I tried doing cfg_kwargs['GIT_MODE'] = False in core/api.py. I thought
> > that
> > > > > would change all expectations back but none changed. Any idea why?
> > > > 
> > > > No clue. I worry that the trybots succeeded by coincidence, or that this
> > will
> > > > work for existing checkouts but not new ones or something like that. I
> think
> > > we
> > > > need to talk to whoever made the change upstream.
> > > 
> > > So looks like GIT_MODE was completely removed in
> > > https://codereview.chromium.org/2286793003 so there is no way to go back.
> > > I suspect under the hood if .DEPS.git is not found then it uses DEPS but I
> am
> > > going to try to confirm that.
> > 
> > Ok, LGTM to get this unblocked but we should verify that there's a fallback.

> > I'm also not familiar with some of the new flags...
> 
> Chromium also only has a DEPS
> (https://chromium.googlesource.com/chromium/src/+/master/DEPS) and no
.DEPS.git.
> 
> I asked Pawel, he said not to worry about it since it works for Chromium.
Aaron
> is OOO. Asked Robbie as well but have not heard back.
> 
> I have no idea about the new flags too. Since this change was done on other
> projects, hopefully it does not break any existing behavior.
> 
> I will aim to submit this late today.

Robbie pointed me to
https://cs.chromium.org/chromium/tools/depot_tools/gclient.py?q=gclient.py&sq...
which shows that DEPS is always the fallback regardless of what you tell gclient
to look for initially.

[borenet, 2016-09-14 18:04:17]

Ok, sg

[rmistry, 2016-09-15 10:21:31]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-09-15 10:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 10:21:42]

COMMIT=false detected. CQ is abandoning the patch.

[rmistry, 2016-09-15 10:42:00]

Description was changed from

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003

COMMIT=false
==========

to

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
==========

[rmistry, 2016-09-15 10:42:07]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-09-15 10:42:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmistry, 2016-09-15 11:49:50]

On 2016/09/15 10:42:10, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Tree is in caution due to failing Roll. I am going to skip tree check and land
this because I want to see if it causes any problems earlier rather than later.

[rmistry, 2016-09-15 11:50:21]

Description was changed from

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
==========

to

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
NOTREECHECKS=true
==========

[rmistry, 2016-09-15 11:50:50]

The CQ bit was unchecked by rmistry@google.com

[rmistry, 2016-09-15 11:50:51]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-09-15 11:51:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:52:23]

Description was changed from

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
NOTREECHECKS=true
==========

to

==========
Roll recipe DEPS

BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
NOTREECHECKS=true

Committed:
https://skia.googlesource.com/skia/+/90d0bfae4eded779c7415d0ec116de3da37b8ae6
==========

[commit-bot: I haz the power, 2016-09-15 11:52:25]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/90d0bfae4eded779c7415d0ec116de3da37b8ae6