Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 2339383002: [turbofan] Handle stack overflow during inlining. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Handle stack overflow during inlining. This handles the case where generating bytecode for inlining purposes causes a stack overflow. We just abort inlining but also need to clear pending exceptions. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-647217 BUG=chromium:647217 Committed: https://crrev.com/c2cf8b11edfef9fce73939c3137de2e65f1a75a6 Cr-Commit-Position: refs/heads/master@{#39448}

Patch Set 1 #

Patch Set 2 : Add regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/compiler/js-inlining.cc View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-647217.js View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-15 12:14:05 UTC) #3
Benedikt Meurer
LGTM once we have a regression test :-)
4 years, 3 months ago (2016-09-15 12:38:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339383002/20001
4 years, 3 months ago (2016-09-15 14:01:57 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 14:04:39 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 14:05:23 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2cf8b11edfef9fce73939c3137de2e65f1a75a6
Cr-Commit-Position: refs/heads/master@{#39448}

Powered by Google App Engine
This is Rietveld 408576698