Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: src/compiler/js-inlining.cc

Issue 2339383002: [turbofan] Handle stack overflow during inlining. (Closed)
Patch Set: Add regression test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-647217.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-inlining.cc
diff --git a/src/compiler/js-inlining.cc b/src/compiler/js-inlining.cc
index 376448e08aab71443c8ae3d08442f5318e4cfc24..58e5a276ccc24dd64bd313ae9983b8c04aec99bb 100644
--- a/src/compiler/js-inlining.cc
+++ b/src/compiler/js-inlining.cc
@@ -482,7 +482,9 @@ Reduction JSInliner::ReduceJSCall(Node* node, Handle<JSFunction> function) {
TRACE("Not inlining %s into %s because bytecode generation failed\n",
shared_info->DebugName()->ToCString().get(),
info_->shared_info()->DebugName()->ToCString().get());
- DCHECK(!info_->isolate()->has_pending_exception());
+ if (info_->isolate()->has_pending_exception()) {
+ info_->isolate()->clear_pending_exception();
+ }
return NoChange();
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-647217.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698