Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2339323003: Remove platform/CheckedInt.h, we can use wtf/CheckedNumeric.h instead. (Closed)

Created:
4 years, 3 months ago by esprehn
Modified:
4 years, 3 months ago
Reviewers:
haraken, dglazkov
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove platform/CheckedInt.h, we can use wtf/CheckedNumeric.h instead. We can remove this duplicate checked math implementation and use the one in base (proxied by way of WTF) instead. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/35b18ffbebddd641ade9ee40f79a443ceb338c70 Cr-Commit-Position: refs/heads/master@{#419042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -862 lines) Patch
M third_party/WebKit/Source/core/dom/DOMDataView.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/CheckedInt.h View 1 chunk +0 lines, -818 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 3 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dglazkov
lgtm
4 years, 3 months ago (2016-09-15 21:59:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339323003/1
4 years, 3 months ago (2016-09-15 23:47:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 23:54:18 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/35b18ffbebddd641ade9ee40f79a443ceb338c70 Cr-Commit-Position: refs/heads/master@{#419042}
4 years, 3 months ago (2016-09-15 23:58:27 UTC) #12
haraken
4 years, 3 months ago (2016-09-16 01:13:57 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698