third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 2339323003: Remove platform/CheckedInt.h, we can use wtf/CheckedNumeric.h instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 2339323003: Remove platform/CheckedInt.h, we can use wtf/CheckedNumeric.h instead. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMDataView.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index ad89f564747c4d18647836e4a2494075ab290dd6..d7baad33761080ec6cfde21b119e18ba02e1bb72 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -24,8 +24,8 @@

#include "modules/webgl/WebGLTransformFeedback.h"

#include "modules/webgl/WebGLUniformLocation.h"

#include "modules/webgl/WebGLVertexArrayObject.h"

-#include "platform/CheckedInt.h"

#include "public/platform/WebGraphicsContext3DProvider.h"

+#include "wtf/CheckedNumeric.h"

#include "wtf/PtrUtil.h"

#include "wtf/text/WTFString.h"

#include <memory>

@@ -58,9 +58,9 @@ bool validateSubSourceAndGetData(DOMArrayBufferView* view, GLuint subOffset, GLu

// type size is at most 8, so no overflow.

byteOffset = subOffset * typeSize;

}

- CheckedInt<long long> total = byteOffset;

+ CheckedNumeric<long long> total = byteOffset;

total += byteLength;

- if (!total.isValid() || total.value() > view->byteLength()) {

+ if (!total.IsValid() || total.ValueOrDie() > view->byteLength()) {

return false;

}

if (!byteLength) {