SkFontData to use smart pointers.

SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002

Committed: https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c
Committed: https://skia.googlesource.com/skia/+/f93d71122e4fcfcdc674a0163455990b13855f2f

[bungeman-skia, 2016-09-14 19:03:04]

Description was changed from

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.
==========

to

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002
==========

[bungeman-skia, 2016-09-14 21:38:20]

Description was changed from

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002
==========

to

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002
==========

[bungeman-skia, 2016-09-14 21:51:49]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 21:51:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-09-14 22:02:51]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-09-14 22:08:38]

bungeman@google.com changed reviewers:
+ halcanary@google.com, mtklein@google.com

[bungeman-skia, 2016-09-14 22:08:39]

Trying to get some low hanging fruit from the smart pointer tree before trying
to update all the actually public API.

[mtklein_C, 2016-09-14 22:17:49]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-09-14 22:17:49]

lgtm

[mtklein_C, 2016-09-14 22:17:52]

lgtm

[reed1, 2016-09-15 13:38:48]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-09-15 13:38:49]

lgtm w/ request

https://codereview.chromium.org/2339273002/diff/20001/include/core/SkStream.h
File include/core/SkStream.h (right):

https://codereview.chromium.org/2339273002/diff/20001/include/core/SkStream.h...
include/core/SkStream.h:53: static SkStreamAsset* NewFromFile(const char path[])
{
can we add a guard to deprecate/remove this version?

[bungeman-skia, 2016-09-15 16:34:35]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 16:34:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-09-15 16:35:47]

https://codereview.chromium.org/2339273002/diff/20001/include/core/SkStream.h
File include/core/SkStream.h (right):

https://codereview.chromium.org/2339273002/diff/20001/include/core/SkStream.h...
include/core/SkStream.h:53: static SkStreamAsset* NewFromFile(const char path[])
{
On 2016/09/15 13:38:49, reed1 wrote:
> can we add a guard to deprecate/remove this version?

I don't see anyone else using it, so I think it can be removed if everything
else updates at the same time.

Done.

[hal.canary, 2016-09-15 16:36:38]

lgtm

[bungeman-skia, 2016-09-15 16:41:33]

Description was changed from

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002
==========

to

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002
==========

[bungeman-skia, 2016-09-15 16:50:53]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-09-15 17:02:04]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2016-09-15 17:02:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mtklein@chromium.org, reed@google.com
Link to the patchset: https://codereview.chromium.org/2339273002/#ps40001
(title: "SkStream::MakeFromFile as well.")

[commit-bot: I haz the power, 2016-09-15 17:02:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 17:03:29]

Description was changed from

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002
==========

to

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002

Committed:
https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c
==========

[commit-bot: I haz the power, 2016-09-15 17:03:30]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c

[bungeman-skia, 2016-09-15 17:57:17]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2343933002/ by bungeman@google.com.

The reason for reverting is: Killing Mac.

[bungeman-skia, 2016-09-15 18:00:21]

Description was changed from

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002

Committed:
https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c
==========

to

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002

Committed:
https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c
==========

[bungeman-skia, 2016-09-15 20:13:19]

Chromium has a subclass of SkTypeface in a test which overrides the changed
files. Added a define to keep Chromium compiling until it can be fixed.

https://codereview.chromium.org/2339273002/diff/40001/src/utils/mac/SkStream_...
File src/utils/mac/SkStream_mac.cpp (right):

https://codereview.chromium.org/2339273002/diff/40001/src/utils/mac/SkStream_...
src/utils/mac/SkStream_mac.cpp:58: delete_stream_proc);
We are turning over ownership of the stream to the CGDataProvider. However, this
release will reset stream to nullptr, so if the order of argument evaluation
means stream is dereferenced later for the call to getLength it will be nullptr.

https://codereview.chromium.org/2339273002/diff/40001/src/utils/mac/SkStream_...
src/utils/mac/SkStream_mac.cpp:76: return
CGDataProviderCreateWithData(data.release(), data->data(), data->size(),
unref_proc);
Same issue here, using 'data' after release().

[bungeman-skia, 2016-09-15 20:13:38]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 20:13:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-09-15 20:36:38]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-09-16 01:24:07]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 01:24:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-09-16 11:50:37]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 11:50:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 12:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 12:22:29]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-09-16 13:22:49]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2016-09-16 13:22:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
halcanary@google.com, mtklein@chromium.org, reed@google.com
Link to the patchset: https://codereview.chromium.org/2339273002/#ps100001
(title: "Add trivial bodies to the trivial implementations.")

[commit-bot: I haz the power, 2016-09-16 13:23:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 13:24:22]

Description was changed from

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002

Committed:
https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c
==========

to

==========
SkFontData to use smart pointers.

The SkFontData type is not exposed externally, so any method which uses
it can be updated to use smart pointers without affecting external
users. Updating this first will make updating the public API much
easier.

This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to
std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It
appears that no one outside Skia is currently using SkStream::NewfromFile
so this is a good time to update it as well.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002

Committed:
https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c
Committed:
https://skia.googlesource.com/skia/+/f93d71122e4fcfcdc674a0163455990b13855f2f
==========

[commit-bot: I haz the power, 2016-09-16 13:24:23]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/f93d71122e4fcfcdc674a0163455990b13855f2f