src/ports/SkFontHost_win.cpp - Issue 2339273002: SkFontData to use smart pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_win.cpp

Issue 2339273002: SkFontData to use smart pointers. (Closed)

Patch Set: Add trivial bodies to the trivial implementations. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_win.cpp

diff --git a/src/ports/SkFontHost_win.cpp b/src/ports/SkFontHost_win.cpp

index ca80baec4ff4b83a235464d88773cc2616b5d034..0e878bee0360d02dc92ad34e5ed4641800d64126 100644

--- a/src/ports/SkFontHost_win.cpp

+++ b/src/ports/SkFontHost_win.cpp

@@ -2463,7 +2463,7 @@ protected:

SkTypeface* onCreateFromFile(const char path[], int ttcIndex) const override {

// could be in base impl

- return this->createFromStream(SkStream::NewFromFile(path));

+ return this->createFromStream(SkStream::MakeFromFile(path).release());

}

SkTypeface* onLegacyCreateTypeface(const char familyName[], SkFontStyle style) const override {

« no previous file with comments | « src/ports/SkFontHost_mac.cpp ('k') | src/ports/SkFontMgr_FontConfigInterface.cpp » ('j') | no next file with comments »