Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: components/cronet/android/api/src/org/chromium/net/ExperimentalUrlRequest.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Rebased onto Charles change + Paul's Comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/ExperimentalUrlRequest.java
diff --git a/components/cronet/android/api/src/org/chromium/net/ExperimentalUrlRequest.java b/components/cronet/android/api/src/org/chromium/net/ExperimentalUrlRequest.java
new file mode 100644
index 0000000000000000000000000000000000000000..66f70e4f13b82ae8253c8c04dc050eb3e0f9c98e
--- /dev/null
+++ b/components/cronet/android/api/src/org/chromium/net/ExperimentalUrlRequest.java
@@ -0,0 +1,33 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+package org.chromium.net;
+
+/**
+ * {@link UrlRequest} that exposes experimental feature.
+ * {@hide} since this class exposes experimental features that should be hidden.
+ */
+public abstract class ExperimentalUrlRequest extends UrlRequest {
+ /**
+ * Builder for building {@link UrlRequest}.
+ */
+ public abstract static class Builder extends UrlRequest.Builder {
+ /**
+ * Disables connection migration for the request if enabled for
+ * the session.
+ * @return the builder to facilitate chaining.
+ */
+ public abstract Builder disableConnectionMigration();
+
+ /**
+ * Associates the annotation object with this request. May add more than one.
+ * Passed through to a {@link RequestFinishedInfo.Listener},
+ * see {@link RequestFinishedInfo#getAnnotations}.
+ *
+ * @param annotation an object to pass on to the {@link RequestFinishedInfo.Listener} with a
+ * {@link RequestFinishedInfo}.
+ * @return the builder to facilitate chaining.
+ */
+ public abstract Builder addRequestAnnotation(Object annotation);
pauljensen 2016/09/26 14:51:21 how come this class doesn't have a build() method,
kapishnikov 2016/09/27 18:38:25 build() is inherited from UrlRequest.Builder. The
pauljensen 2016/09/27 19:08:09 Agreed to add it and make it abstract.
kapishnikov 2016/09/28 00:20:49 Done. Same for ExperimentalBidirectionalStream.Bui
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698