Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: components/cronet/android/api/src/org/chromium/net/ExperimentalUrlRequest.java

Issue 2339223002: Cronet API Refactoring (Closed)
Patch Set: Rebased onto Charles change + Paul's Comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 package org.chromium.net;
5
6 /**
7 * {@link UrlRequest} that exposes experimental feature.
8 * {@hide} since this class exposes experimental features that should be hidden.
9 */
10 public abstract class ExperimentalUrlRequest extends UrlRequest {
11 /**
12 * Builder for building {@link UrlRequest}.
13 */
14 public abstract static class Builder extends UrlRequest.Builder {
15 /**
16 * Disables connection migration for the request if enabled for
17 * the session.
18 * @return the builder to facilitate chaining.
19 */
20 public abstract Builder disableConnectionMigration();
21
22 /**
23 * Associates the annotation object with this request. May add more than one.
24 * Passed through to a {@link RequestFinishedInfo.Listener},
25 * see {@link RequestFinishedInfo#getAnnotations}.
26 *
27 * @param annotation an object to pass on to the {@link RequestFinishedI nfo.Listener} with a
28 * {@link RequestFinishedInfo}.
29 * @return the builder to facilitate chaining.
30 */
31 public abstract Builder addRequestAnnotation(Object annotation);
pauljensen 2016/09/26 14:51:21 how come this class doesn't have a build() method,
kapishnikov 2016/09/27 18:38:25 build() is inherited from UrlRequest.Builder. The
pauljensen 2016/09/27 19:08:09 Agreed to add it and make it abstract.
kapishnikov 2016/09/28 00:20:49 Done. Same for ExperimentalBidirectionalStream.Bui
32 }
33 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698