Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2339213003: Reland of Refactor the various locale_paks() templates to be more shared (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Refactor the various locale_paks() templates to be more shared Reverted by: https://codereview.chromium.org/2338213002/ Reason for reland: Now gn gens for enable_resource_whitelist_generation = true Main motivation for this is to more easily add per-target repack_whitelist. TBR=michaelbai@chromium.org,thakis@chromium.org,agrieve@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org BUG=645716 Committed: https://crrev.com/659ad253f3680306a5aa2b7307854cc71342802d Cr-Commit-Position: refs/heads/master@{#418859}

Patch Set 1 #

Patch Set 2 : Fix output path of the repack template on iOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -532 lines) Patch
M android_webview/webview_repack_locales.gni View 1 chunk +11 lines, -89 lines 0 comments Download
M android_webview/webview_repack_locales_list.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 4 chunks +16 lines, -2 lines 0 comments Download
M chrome/android/monochrome_repack_locales.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_locales.gni View 5 chunks +44 lines, -143 lines 0 comments Download
M ios/chrome/app/resources/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/app/resources/ios_chrome_repack.gni View 4 chunks +17 lines, -143 lines 0 comments Download
M ios/chrome/extension_repack.gni View 1 chunk +9 lines, -107 lines 0 comments Download
M ios/chrome/share_extension/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/today_extension/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/grit/repack.gni View 1 3 chunks +119 lines, -41 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sdefresne
Andrew: please take a look.
4 years, 3 months ago (2016-09-15 11:20:58 UTC) #5
agrieve
On 2016/09/15 11:20:58, sdefresne wrote: > Andrew: please take a look. lgtm. Thanks for fixing ...
4 years, 3 months ago (2016-09-15 13:52:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339213003/20001
4 years, 3 months ago (2016-09-15 13:53:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 13:58:09 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 14:00:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/659ad253f3680306a5aa2b7307854cc71342802d
Cr-Commit-Position: refs/heads/master@{#418859}

Powered by Google App Engine
This is Rietveld 408576698