Issue 2339033002: Remove DCHECK from the component updater background downloader code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2339033002: Remove DCHECK from the component updater background downloader code. (Closed)

Created:
4 years, 3 months ago by Sorin Jianu

Modified:
4 years, 3 months ago

Reviewers:
waffles

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Remove DCHECK from the component updater background downloader code. The threading issue needs to be fixed according to crbug.com/644857 R=waffles BUG=644854 Review-Url: https://codereview.chromium.org/2322733002 Cr-Commit-Position: refs/heads/master@{#417103} (cherry picked from commit c1210527860aafd4b24f0b91b9934ed19eac4aac) Committed: https://chromium.googlesource.com/chromium/src/+/52e7ddd7ae28dd2947d4a8f10e3788a5341e8871

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	components/update_client/background_downloader_win.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Sorin Jianu

4 years, 3 months ago (2016-09-13 23:45:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
52e7ddd7ae28dd2947d4a8f10e3788a5341e8871.