Query compositing state only from UpdateAnimationState

Query compositing state only from UpdateAnimationState

https://codereview.chromium.org/2029323003 attempted to add an optimization
that would run an animation on the MT by querying m_scrollableArea->
shouldScrollOnMainThread. This was wrong because we were querying compositing
state outside of the CompositingClean state.

This reverts that CL.

The original bug was not fixed in the CL that this reverts and that CL was
just wrong.

This CL doesn't have a behavioral change.

BUG=639100
Committed: https://crrev.com/2153328998af9d61ff8d7743a2f5bc74f889e7f3
Cr-Commit-Position: refs/heads/master@{#418596}

[ymalik, 2016-09-13 18:37:12]

ymalik@chromium.org changed reviewers:
+ ajuma@chromium.org

[ymalik, 2016-09-13 18:37:26]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:38:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:18:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 20:18:41]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-09-13 21:54:29]

Could you explain a bit about how this still fixes the original bug? (that is,
expand on the "This almost reverts that CL." part of the description.)

[ymalik, 2016-09-13 22:02:09]

On 2016/09/13 21:54:29, ajuma wrote:
> Could you explain a bit about how this still fixes the original bug? (that is,
> expand on the "This almost reverts that CL." part of the description.)

The original bug was not fixed in the CL that this reverts. I thought I was
making an optimization anyway by calling
m_scrollableArea->shouldScrollOnMainThread and starting the animation on MT if
it returned true, but its wrong to make that call from anywhere but
::UpdateAnimationState (which is why it was the way it was before I made that
change). By "almost revert", I mean I didn't simply git revert it because that
CL was also fixing a test and refactoring the createAnimationCurve function,
which seems cleaner to me. Does that make sense?

[ajuma, 2016-09-13 22:06:46]

On 2016/09/13 22:02:09, ymalik wrote:
> On 2016/09/13 21:54:29, ajuma wrote:
> > Could you explain a bit about how this still fixes the original bug? (that
is,
> > expand on the "This almost reverts that CL." part of the description.)
> 
> The original bug was not fixed in the CL that this reverts. I thought I was
> making an optimization anyway by calling
> m_scrollableArea->shouldScrollOnMainThread and starting the animation on MT if
> it returned true, but its wrong to make that call from anywhere but
> ::UpdateAnimationState (which is why it was the way it was before I made that
> change). By "almost revert", I mean I didn't simply git revert it because that
> CL was also fixing a test and refactoring the createAnimationCurve function,
> which seems cleaner to me. Does that make sense?

Thanks, that makes sense (please put some of this into the description). lgtm

[ymalik, 2016-09-14 14:33:58]

Description was changed from

==========
Query compositing state only from UpdateAnimationState

https://codereview.chromium.org/2029323003 attempted to add an optimization
that would run an animation on the MT by querying m_scrollableArea->
shouldScrollOnMainThread. This was wrong because we were querying compositing
state outside of the CompositingClean state.

This almost reverts that CL.
This CL doesn't have a behavioral change.

BUG=639100
==========

to

==========
Query compositing state only from UpdateAnimationState

https://codereview.chromium.org/2029323003 attempted to add an optimization
that would run an animation on the MT by querying m_scrollableArea->
shouldScrollOnMainThread. This was wrong because we were querying compositing
state outside of the CompositingClean state.

This reverts that CL.

The original bug was not fixed in the CL that this reverts and that CL was
just wrong.

This CL doesn't have a behavioral change.

BUG=639100
==========

[ymalik, 2016-09-14 14:34:20]

ymalik@chromium.org changed reviewers:
+ jbroman@chromium.org

[ymalik, 2016-09-14 14:34:21]

+jbroman for Source/platform

[jbroman, 2016-09-14 14:56:21]

lgtm

[ymalik, 2016-09-14 17:02:07]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2016-09-14 17:02:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 17:07:54]

Description was changed from

==========
Query compositing state only from UpdateAnimationState

https://codereview.chromium.org/2029323003 attempted to add an optimization
that would run an animation on the MT by querying m_scrollableArea->
shouldScrollOnMainThread. This was wrong because we were querying compositing
state outside of the CompositingClean state.

This reverts that CL.

The original bug was not fixed in the CL that this reverts and that CL was
just wrong.

This CL doesn't have a behavioral change.

BUG=639100
==========

to

==========
Query compositing state only from UpdateAnimationState

https://codereview.chromium.org/2029323003 attempted to add an optimization
that would run an animation on the MT by querying m_scrollableArea->
shouldScrollOnMainThread. This was wrong because we were querying compositing
state outside of the CompositingClean state.

This reverts that CL.

The original bug was not fixed in the CL that this reverts and that CL was
just wrong.

This CL doesn't have a behavioral change.

BUG=639100
==========

[commit-bot: I haz the power, 2016-09-14 17:07:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-14 17:09:43]

Description was changed from

==========
Query compositing state only from UpdateAnimationState

https://codereview.chromium.org/2029323003 attempted to add an optimization
that would run an animation on the MT by querying m_scrollableArea->
shouldScrollOnMainThread. This was wrong because we were querying compositing
state outside of the CompositingClean state.

This reverts that CL.

The original bug was not fixed in the CL that this reverts and that CL was
just wrong.

This CL doesn't have a behavioral change.

BUG=639100
==========

to

==========
Query compositing state only from UpdateAnimationState

https://codereview.chromium.org/2029323003 attempted to add an optimization
that would run an animation on the MT by querying m_scrollableArea->
shouldScrollOnMainThread. This was wrong because we were querying compositing
state outside of the CompositingClean state.

This reverts that CL.

The original bug was not fixed in the CL that this reverts and that CL was
just wrong.

This CL doesn't have a behavioral change.

BUG=639100

Committed: https://crrev.com/2153328998af9d61ff8d7743a2f5bc74f889e7f3
Cr-Commit-Position: refs/heads/master@{#418596}
==========

[commit-bot: I haz the power, 2016-09-14 17:09:44]

Patchset 1 (id:??) landed as
https://crrev.com/2153328998af9d61ff8d7743a2f5bc74f889e7f3
Cr-Commit-Position: refs/heads/master@{#418596}