Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: ui/base/page_transition_types.h

Issue 2338703003: [NTP] Fix article suggestion clicks contributing to Most Visited tiles (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/protocol/session_specifics.proto ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/page_transition_types.h
diff --git a/ui/base/page_transition_types.h b/ui/base/page_transition_types.h
index eafea5237651e9513b2677804968c8d265a18a66..f0244710b3c2fe1768c84a9bdf80e142e0611afa 100644
--- a/ui/base/page_transition_types.h
+++ b/ui/base/page_transition_types.h
@@ -109,6 +109,9 @@ enum PageTransition {
// Any of the core values above can be augmented by one or more qualifiers.
// These qualifiers further define the transition.
+ // The visited URL won't contribute to Most Visited tiles in the NTP.
Bernhard Bauer 2016/09/13 13:14:40 Should we call this just "NTP tiles"? "Most Visite
mastiz 2016/09/13 14:11:55 Done.
+ PAGE_TRANSITION_IGNORE_FOR_NTP_MOST_VISITED = 0x00400000,
Marc Treib 2016/09/13 13:18:20 This seems unnecessarily specific. Can we call it
mastiz 2016/09/13 14:11:55 As discussed offline: unless you feel strongly or
+
// A managed user attempted to visit a URL but was blocked.
PAGE_TRANSITION_BLOCKED = 0x00800000,
« no previous file with comments | « components/sync/protocol/session_specifics.proto ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698