Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Side by Side Diff: ui/base/page_transition_types.h

Issue 2338703003: [NTP] Fix article suggestion clicks contributing to Most Visited tiles (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync/protocol/session_specifics.proto ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_BASE_PAGE_TRANSITION_TYPES_H_ 5 #ifndef UI_BASE_PAGE_TRANSITION_TYPES_H_
6 #define UI_BASE_PAGE_TRANSITION_TYPES_H_ 6 #define UI_BASE_PAGE_TRANSITION_TYPES_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "ui/base/ui_base_export.h" 10 #include "ui/base/ui_base_export.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 102
103 // ADDING NEW CORE VALUE? Be sure to update the LAST_CORE and CORE_MASK 103 // ADDING NEW CORE VALUE? Be sure to update the LAST_CORE and CORE_MASK
104 // values below. Also update CoreTransitionString(). 104 // values below. Also update CoreTransitionString().
105 PAGE_TRANSITION_LAST_CORE = PAGE_TRANSITION_KEYWORD_GENERATED, 105 PAGE_TRANSITION_LAST_CORE = PAGE_TRANSITION_KEYWORD_GENERATED,
106 PAGE_TRANSITION_CORE_MASK = 0xFF, 106 PAGE_TRANSITION_CORE_MASK = 0xFF,
107 107
108 // Qualifiers 108 // Qualifiers
109 // Any of the core values above can be augmented by one or more qualifiers. 109 // Any of the core values above can be augmented by one or more qualifiers.
110 // These qualifiers further define the transition. 110 // These qualifiers further define the transition.
111 111
112 // The visited URL won't contribute to Most Visited tiles in the NTP.
Bernhard Bauer 2016/09/13 13:14:40 Should we call this just "NTP tiles"? "Most Visite
mastiz 2016/09/13 14:11:55 Done.
113 PAGE_TRANSITION_IGNORE_FOR_NTP_MOST_VISITED = 0x00400000,
Marc Treib 2016/09/13 13:18:20 This seems unnecessarily specific. Can we call it
mastiz 2016/09/13 14:11:55 As discussed offline: unless you feel strongly or
114
112 // A managed user attempted to visit a URL but was blocked. 115 // A managed user attempted to visit a URL but was blocked.
113 PAGE_TRANSITION_BLOCKED = 0x00800000, 116 PAGE_TRANSITION_BLOCKED = 0x00800000,
114 117
115 // User used the Forward or Back button to navigate among browsing history. 118 // User used the Forward or Back button to navigate among browsing history.
116 PAGE_TRANSITION_FORWARD_BACK = 0x01000000, 119 PAGE_TRANSITION_FORWARD_BACK = 0x01000000,
117 120
118 // User used the address bar to trigger this navigation. 121 // User used the address bar to trigger this navigation.
119 PAGE_TRANSITION_FROM_ADDRESS_BAR = 0x02000000, 122 PAGE_TRANSITION_FROM_ADDRESS_BAR = 0x02000000,
120 123
121 // User is navigating to the home page. 124 // User is navigating to the home page.
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 // PageTransitionCoreTypeIs() instead or, in rare cases, 199 // PageTransitionCoreTypeIs() instead or, in rare cases,
197 // PageTransitionTypeIncludingQualifiersIs(). 200 // PageTransitionTypeIncludingQualifiersIs().
198 DontUseOperatorEquals operator==(PageTransition, PageTransition); 201 DontUseOperatorEquals operator==(PageTransition, PageTransition);
199 DontUseOperatorEquals operator==(PageTransition, int); 202 DontUseOperatorEquals operator==(PageTransition, int);
200 DontUseOperatorEquals operator==(int, PageTransition); 203 DontUseOperatorEquals operator==(int, PageTransition);
201 #endif // defined(CONTENT_IMPLEMENTATION) 204 #endif // defined(CONTENT_IMPLEMENTATION)
202 205
203 } // namespace ui 206 } // namespace ui
204 207
205 #endif // UI_BASE_PAGE_TRANSITION_TYPES_H_ 208 #endif // UI_BASE_PAGE_TRANSITION_TYPES_H_
OLDNEW
« no previous file with comments | « components/sync/protocol/session_specifics.proto ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698