Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2338693002: Measure bandwidth utilization in the scroll perf test (Closed)

Created:
4 years, 3 months ago by Sergey Ulanov
Modified:
4 years, 3 months ago
Reviewers:
Irfan
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure bandwidth utilization in the ScrollPerformance test Now ScrollPerformance also reports network bandwidth utilization. Also removed two outdated tests: StreamFrameRate and IntermittentChanges. These tests were intended mainly to evaluate performance of the PseudoTCP layer and they were using verbatim video codec. They are not applicable for WebRTC-based protocol. Also the protocol perf tests have been updated to use SoftwareVideoRenderer which allows to get FrameStats when using ICE protocol and this approach is not compatible with the old tests. Bandwidth utilization numbers I get currently with 8Mbps bandwidth: ICE: 93% WebRTC: varies from 21 to 25% The second number also goes to 32 when I change test length and warm-up time to 5 seconds. This suggests that the problem is partly that the bandwidth estimate in WebRTC is below the actual bandwidth in the test and it takes a lot of time to ramp up. BUG=645656 Committed: https://crrev.com/d5ce2225173ec41804750d3de0211408ba096bb9 Cr-Commit-Position: refs/heads/master@{#418444}

Patch Set 1 : . #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : units #

Patch Set 4 : header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -160 lines) Patch
M remoting/test/protocol_perftest.cc View 1 2 3 15 chunks +57 lines, -160 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Sergey Ulanov
4 years, 3 months ago (2016-09-13 17:37:56 UTC) #4
Irfan
https://codereview.chromium.org/2338693002/diff/40001/remoting/test/protocol_perftest.cc File remoting/test/protocol_perftest.cc (right): https://codereview.chromium.org/2338693002/diff/40001/remoting/test/protocol_perftest.cc#newcode214 remoting/test/protocol_perftest.cc:214: EXPECT_GE(frame_stats_.size(), num_expected_frame_stats_); should this be EXPECT_EQ ? https://codereview.chromium.org/2338693002/diff/40001/remoting/test/protocol_perftest.cc#newcode581 remoting/test/protocol_perftest.cc:581: ...
4 years, 3 months ago (2016-09-13 20:19:16 UTC) #5
Sergey Ulanov
https://codereview.chromium.org/2338693002/diff/40001/remoting/test/protocol_perftest.cc File remoting/test/protocol_perftest.cc (right): https://codereview.chromium.org/2338693002/diff/40001/remoting/test/protocol_perftest.cc#newcode214 remoting/test/protocol_perftest.cc:214: EXPECT_GE(frame_stats_.size(), num_expected_frame_stats_); On 2016/09/13 20:19:15, Irfan wrote: > should ...
4 years, 3 months ago (2016-09-13 20:37:39 UTC) #6
Irfan
lgtm
4 years, 3 months ago (2016-09-13 21:20:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338693002/60001
4 years, 3 months ago (2016-09-13 21:48:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/85168)
4 years, 3 months ago (2016-09-13 22:25:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338693002/2
4 years, 3 months ago (2016-09-14 00:32:59 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:2)
4 years, 3 months ago (2016-09-14 01:18:42 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 01:20:30 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d5ce2225173ec41804750d3de0211408ba096bb9
Cr-Commit-Position: refs/heads/master@{#418444}

Powered by Google App Engine
This is Rietveld 408576698