Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2338653002: [NaCl SDK] Disable building PNaCl component (Closed)

Created:
4 years, 3 months ago by Sam Clegg
Modified:
4 years, 3 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Disable building PNaCl component The build is currently broken due to dependency on deleted gyp files. Disabling for now until we can switch the build to GN. BUG=646241 Committed: https://crrev.com/2399cf807375011a06d86c98108164f2eeb379e1 Cr-Commit-Position: refs/heads/master@{#418322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sam Clegg
4 years, 3 months ago (2016-09-13 18:03:33 UTC) #2
bradn
lgtm
4 years, 3 months ago (2016-09-13 18:12:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338653002/1
4 years, 3 months ago (2016-09-13 18:13:10 UTC) #6
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 3 months ago (2016-09-13 19:03:45 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 19:04:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2399cf807375011a06d86c98108164f2eeb379e1
Cr-Commit-Position: refs/heads/master@{#418322}

Powered by Google App Engine
This is Rietveld 408576698