Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 2338653002: [NaCl SDK] Disable building PNaCl component (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/build_sdk.py
diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py
index 53377002ae028f71b8d7b0b2253a3d246bdd9f9e..e010b3be52842a4b052b2a42c7f463e701e159bb 100755
--- a/native_client_sdk/src/build_tools/build_sdk.py
+++ b/native_client_sdk/src/build_tools/build_sdk.py
@@ -853,8 +853,11 @@ def main(args):
if options.tar:
BuildStepTarBundle(pepper_ver, tarfile)
- if platform == 'linux':
- BuildStepBuildPNaClComponent(pepper_ver, chrome_revision)
+ # TODO(sbc): Re-enable this once we switch the pnacl component build
+ # from gyp to gn:
+ # https://bugs.chromium.org/p/chromium/issues/detail?id=646241
+ #if platform == 'linux':
+ #BuildStepBuildPNaClComponent(pepper_ver, chrome_revision)
if options.build_app_engine and platform == 'linux':
BuildStepBuildAppEngine(pepperdir, chrome_revision)
@@ -870,7 +873,7 @@ def main(args):
# Only archive sdk_tools/naclport/pnacl_component on linux.
if platform == 'linux':
BuildStepArchiveSDKTools()
- BuildStepArchivePNaClComponent(chrome_revision)
+ #BuildStepArchivePNaClComponent(chrome_revision)
return 0
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698