Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2338553002: Stop converting widestring -> c_str -> widestring in several places. (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Stop converting widestring -> c_str -> widestring in several places. Avoids a needless alloc and copy. Committed: https://pdfium.googlesource.com/pdfium/+/067990ccf96ae962392a2dbacbfd8348dc4c7676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -64 lines) Patch
M core/fpdfdoc/cpdf_variabletext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/include/cpdf_variabletext.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 3 chunks +4 lines, -9 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fxedit/fxet_list.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fxedit/include/fxet_list.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.h View 1 chunk +2 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.cpp View 3 chunks +7 lines, -13 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-12 22:57:48 UTC) #2
dsinclair
lgtm
4 years, 3 months ago (2016-09-13 13:23:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338553002/1
4 years, 3 months ago (2016-09-13 13:23:57 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 13:46:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/067990ccf96ae962392a2dbacbfd8348dc4c...

Powered by Google App Engine
This is Rietveld 408576698