fpdfsdk/formfiller/cffl_listbox.cpp - Issue 2338553002: Stop converting widestring -> c_str -> widestring in several places.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/formfiller/cffl_listbox.cpp

Issue 2338553002: Stop converting widestring -> c_str -> widestring in several places. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/formfiller/cffl_listbox.cpp

diff --git a/fpdfsdk/formfiller/cffl_listbox.cpp b/fpdfsdk/formfiller/cffl_listbox.cpp

index 36950bd2b234eca6f05ffc33b9c488662cc3b6b8..860fd07a75f9b9e54ab002746d716114106d18bc 100644

--- a/fpdfsdk/formfiller/cffl_listbox.cpp

+++ b/fpdfsdk/formfiller/cffl_listbox.cpp

@@ -52,7 +52,7 @@ CPWL_Wnd* CFFL_ListBox::NewPDFWindow(const PWL_CREATEPARAM& cp,

pWnd->SetFillerNotify(pIFormFiller);

for (int32_t i = 0, sz = m_pWidget->CountOptions(); i < sz; i++)

- pWnd->AddString(m_pWidget->GetOptionLabel(i).c_str());

+ pWnd->AddString(m_pWidget->GetOptionLabel(i));

if (pWnd->HasFlag(PLBS_MULTIPLESEL)) {

m_OriginSelections.clear();

« no previous file with comments | « fpdfsdk/formfiller/cffl_combobox.cpp ('k') | fpdfsdk/formfiller/cffl_textfield.cpp » ('j') | no next file with comments »