Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2338483003: Revert of services/ui: Use new gpu::GpuInit to do the GPU initialization. (Closed)

Created:
4 years, 3 months ago by lazyboy
Modified:
4 years, 3 months ago
Reviewers:
Fady Samuel, sadrul, sky
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of services/ui: Use new gpu::GpuInit to do the GPU initialization. (patchset #3 id:40001 of https://codereview.chromium.org/2329543002/ ) Reason for revert: Lots of mus_ws_unittests started failing on Linux Tests dbg and Linux Tests, e.g.: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/33286 BUG=646186 Original issue's description: > services/ui: Use new gpu::GpuInit to do the GPU initialization. > > BUG=643746 > > Committed: https://crrev.com/8b2d8a7287c3a02a2398aded54429d5b2f1b411a > Cr-Commit-Position: refs/heads/master@{#418062} TBR=fsamuel@chromium.org,sky@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643746 Committed: https://crrev.com/1de77ecc00dc3cad6363919340d80e06f8b920bc Cr-Commit-Position: refs/heads/master@{#418105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -118 lines) Patch
M services/ui/gpu/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D services/ui/gpu/gpu_main.h View 1 chunk +0 lines, -42 lines 0 comments Download
D services/ui/gpu/gpu_main.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.h View 6 chunks +14 lines, -11 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 6 chunks +26 lines, -9 lines 0 comments Download
M services/ui/ws/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
lazyboy
Created Revert of services/ui: Use new gpu::GpuInit to do the GPU initialization.
4 years, 3 months ago (2016-09-12 23:39:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338483003/1
4 years, 3 months ago (2016-09-12 23:40:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 23:41:21 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 23:43:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1de77ecc00dc3cad6363919340d80e06f8b920bc
Cr-Commit-Position: refs/heads/master@{#418105}

Powered by Google App Engine
This is Rietveld 408576698