Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2338293004: In update_w3c_test_expectations, do nothing when there are no new lines to add. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In update_w3c_test_expectations, do nothing when there are no new lines to add. BUG=647395 Committed: https://crrev.com/b62f63468f84210243aa8cef38c5a087b4a8c291 Cr-Commit-Position: refs/heads/master@{#419257}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
qyearsley
4 years, 3 months ago (2016-09-15 23:07:51 UTC) #2
qyearsley
There is a related refactoring CL (http://crbug.com/2349543002) -- if that one is committed first then ...
4 years, 3 months ago (2016-09-15 23:08:47 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-16 00:34:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338293004/20001
4 years, 3 months ago (2016-09-16 18:32:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 19:51:20 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:54:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b62f63468f84210243aa8cef38c5a087b4a8c291
Cr-Commit-Position: refs/heads/master@{#419257}

Powered by Google App Engine
This is Rietveld 408576698