third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py - Issue 2338293004: In update_w3c_test_expectations, do nothing when there are no new lines to add.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py

Issue 2338293004: In update_w3c_test_expectations, do nothing when there are no new lines to add. (Closed)

Patch Set: Rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py

index f999e44ff83ae1a385c8e36e711b86366c3f6f02..a578105edd64dee19a2663c345d67b4e82249fd0 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py

@@ -271,6 +271,8 @@ class W3CExpectationsLineAdder(object):

file_contents = self.host.filesystem.read_text_file(expectations_file_path)

marker_comment_index = file_contents.find(marker_comment)

line_list = [line for line in line_list if self._test_name_from_expectation_string(line) not in file_contents]

+ if not line_list:

+ return

if marker_comment_index == -1:

file_contents += '\n%s\n' % marker_comment

file_contents += '\n'.join(line_list)

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py » ('j') | no next file with comments »