Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4713)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/findit/model/crash/crash_config.py

Issue 2338273006: [Findit] Factoring out the components, so they can classify themselves (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« appengine/findit/crash/test/component_classifier_test.py ('K') | « appengine/findit/crash/test/component_classifier_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/crash/crash_config.py
diff --git a/appengine/findit/model/crash/crash_config.py b/appengine/findit/model/crash/crash_config.py
index 8774b1004856fc30d5b49b67e5d23b28db370ac5..faa29a255e30b50559b026afd1d7bab6622e0e98 100644
--- a/appengine/findit/model/crash/crash_config.py
+++ b/appengine/findit/model/crash/crash_config.py
@@ -93,6 +93,7 @@ class CrashConfig(VersionedConfig):
compiled_path_function_component = []
for path, function, component in self.component_classifier[
'path_function_component']:
+ # TODO(wrengr): build Component objects here, rather than doing so later
stgao 2016/09/21 21:57:27 nit: end with dot like this.
wrengr 2016/09/27 22:00:40 Done.
compiled_path_function_component.append(
[re.compile(path),
re.compile(function) if function else None,
« appengine/findit/crash/test/component_classifier_test.py ('K') | « appengine/findit/crash/test/component_classifier_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698