[Findit] Factoring out the components, so they can classify themselves

appengine/findit/model/crash/crash_config.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Findit for crash (ClusterFuzz & Fracas/Chromecrash) configuration."""
 
 import re
 
 from google.appengine.ext import ndb
 
@@ skipping 75 matching lines @@
   def ClearCache(self):
     self.cached_component_classifier = None
 
   @property
   def compiled_component_classifier(self):
     """Returns the component classifier with all re patterns compiled."""
     if self.cached_component_classifier is None and self.component_classifier:
       compiled_path_function_component = []
       for path, function, component in self.component_classifier[
           'path_function_component']:
+        # TODO(wrengr): build Component objects here, rather than doing so later

[stgao, 2016/09/21 21:57:27]

nit: end with dot like this.

[wrengr, 2016/09/27 22:00:40]

Done.

         compiled_path_function_component.append(
             [re.compile(path),
              re.compile(function) if function else None,
              component])
 
       self.cached_component_classifier = {
           'top_n': self.component_classifier['top_n'],
           'path_function_component': compiled_path_function_component
       }
 
     return self.cached_component_classifier