Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2338253002: Fix the bug that "Open" button doesn't show after WebAPK installation is complete on Jellybean. (Closed)

Created:
4 years, 3 months ago by Xi Han
Modified:
4 years, 3 months ago
Reviewers:
pkotwicz, gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the bug that "Open" button doesn't show after WebAPK installation is complete on Jellybean. This is caused in WebApkInstaller::OnSucess() which uses a local variable after deleting the "this" pointer. Therefore, a wrong package name is given to the infobar and the infobar believes the WebAPK hasn't been installed yet. BUG=646844 Committed: https://crrev.com/14565db671121404c1d00c0bd959d847f0f97b0d Cr-Commit-Position: refs/heads/master@{#418610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/android/webapk/webapk_installer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Xi Han
Hi Peter, please take a look, thanks!
4 years, 3 months ago (2016-09-14 13:45:06 UTC) #3
pkotwicz
lgtm
4 years, 3 months ago (2016-09-14 14:14:43 UTC) #5
Xi Han
Hi Dan, I need OWNERS review, please take a look, thanks!
4 years, 3 months ago (2016-09-14 14:16:28 UTC) #7
gone
lgtm
4 years, 3 months ago (2016-09-14 17:01:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338253002/1
4 years, 3 months ago (2016-09-14 17:02:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 18:13:04 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:14:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14565db671121404c1d00c0bd959d847f0f97b0d
Cr-Commit-Position: refs/heads/master@{#418610}

Powered by Google App Engine
This is Rietveld 408576698