chrome/browser/android/webapk/webapk_installer.cc - Issue 2338253002: Fix the bug that "Open" button doesn't show after WebAPK installation is complete on Jellybean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapk/webapk_installer.cc

Issue 2338253002: Fix the bug that "Open" button doesn't show after WebAPK installation is complete on Jellybean. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapk/webapk_installer.cc

diff --git a/chrome/browser/android/webapk/webapk_installer.cc b/chrome/browser/android/webapk/webapk_installer.cc

index b38f494c94cba71ace674e2bcf12389fc7c9c6bf..a0cf1c15a64f773daf504423436730c4630f2015 100644

--- a/chrome/browser/android/webapk/webapk_installer.cc

+++ b/chrome/browser/android/webapk/webapk_installer.cc

@@ -418,8 +418,9 @@ void WebApkInstaller::OnTimeout() {

void WebApkInstaller::OnSuccess() {

FinishCallback callback = finish_callback_;

+ std::string webapk_package = webapk_package_;

delete this;

- callback.Run(true, webapk_package_);

+ callback.Run(true, webapk_package);

}

void WebApkInstaller::OnFailure() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »