Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2338233003: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in previous/nextLinePosition (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in previous/nextLinePosition BUG=590369 Committed: https://crrev.com/64d0537a1c9036994fbf1c46c2f2cb1db50892b1 Cr-Commit-Position: refs/heads/master@{#419109}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionModifier.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-15 16:02:53 UTC) #10
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-16 06:00:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338233003/20001
4 years, 3 months ago (2016-09-16 06:00:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 06:04:38 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 06:06:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64d0537a1c9036994fbf1c46c2f2cb1db50892b1
Cr-Commit-Position: refs/heads/master@{#419109}

Powered by Google App Engine
This is Rietveld 408576698