third_party/WebKit/Source/core/editing/VisibleUnits.cpp - Issue 2338233003: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in previous/nextLinePosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2338233003: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in previous/nextLinePosition (Closed)

Patch Set: Rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

index d1a09bf8e121ff27ee436be9dfe43d09826ae7d9..132f066d80958bcb48e06c41064312f707aacfa3 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

@@ -1343,7 +1343,7 @@ VisiblePosition previousLinePosition(const VisiblePosition& visiblePosition, Lay

if (!node)

return VisiblePosition();

- node->document().updateStyleAndLayoutIgnorePendingStylesheets();

+ DCHECK(!node->document().needsLayoutTreeUpdate());

LayoutObject* layoutObject = node->layoutObject();

if (!layoutObject)