Unassociating MediaSession from media players (in blink & content)

Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

This is part of a greater effort of making MediaSession API
implementation in sync with the spec.
https://docs.google.com/a/google.com/document/d/1RNaWRpEDCGfDI5HEmMYxqA2QaD2eAOuhTlmuKoWMA8Y/edit?usp=sharing

BUG=646906
Committed: https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147
Cr-Commit-Position: refs/heads/master@{#420418}

[Zhiqiang Zhang (Slow), 2016-09-14 17:02:08]

Description was changed from

==========
Unassociating MediaSession from media players (in blink & content)

BUG=646906
==========

to

==========
Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

BUG=646906
==========

[Zhiqiang Zhang (Slow), 2016-09-14 17:04:57]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org, dalecurtis@chromium.org, mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-09-14 17:06:44]

Description was changed from

==========
Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

BUG=646906
==========

to

==========
Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

This is part of a greater effort of making MediaSession API
implementation in sync with the spec.
https://docs.google.com/a/google.com/document/d/1RNaWRpEDCGfDI5HEmMYxqA2QaD2e...

BUG=646906
==========

[DaleCurtis, 2016-09-14 19:32:35]

Nice cleanup, media/ lgtm

[whywhat, 2016-09-14 22:51:14]

huh, the code I was going to get inspired from is going away...

modules/mediasession lgtm (you should add yourself to OWNERS in a separate CL
perhaps?)

[mlamouri (slow - plz ping), 2016-09-15 10:34:14]

lgtm - thanks zqzhang@ :)

Can you CC davve@opera.com and add foolip@ as a reviewer (might be needed for
WebKit/ stuff.

[Zhiqiang Zhang (Slow), 2016-09-15 13:12:46]

zqzhang@chromium.org changed reviewers:
+ clamy@chromium.org, foolip@chromium.org, mkwst@chromium.org

[Zhiqiang Zhang (Slow), 2016-09-15 13:12:47]

+foolip to review:
WebKit/.../FrameLoaderClientImpl.cpp
WebKit/.../WebFrameClient.h

+mkwst to review:
media_player_messages_android.h

+clamy to review:
render_frame_impl.*

[clamy, 2016-09-15 13:19:45]

content/ lgtm. Don't forget to add a reviewer for the content IPC changes.

[Zhiqiang Zhang (Slow), 2016-09-22 09:28:12]

zqzhang@chromium.org changed reviewers:
+ tsepez@chromium.org
- mkwst@chromium.org

[Zhiqiang Zhang (Slow), 2016-09-22 09:28:15]

+tsepez for reviewing IPC changes.

Friendly ping!
foolip@, can you approve changes in third_party/WebKit?

[foolip, 2016-09-22 11:23:55]

On 2016/09/22 09:28:15, Zhiqiang Zhang wrote:
> +tsepez for reviewing IPC changes.
> 
> Friendly ping!
> foolip@, can you approve changes in third_party/WebKit?

rs lgtm, although as commented in a design doc, I'm not sure how media buttons
can work if the session doesn't know about the players, but we'll see :)

[Tom Sepez, 2016-09-22 16:50:56]

Message LGTM.

[Zhiqiang Zhang (Slow), 2016-09-22 17:10:22]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-09-22 17:10:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
avayvod@chromium.org, dalecurtis@chromium.org, mlamouri@chromium.org,
foolip@chromium.org, tsepez@chromium.org, clamy@chromium.org
Link to the patchset: https://codereview.chromium.org/2338223003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-22 17:10:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:29:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhiqiang Zhang (Slow), 2016-09-22 18:01:47]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-09-22 18:01:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org, dalecurtis@chromium.org, foolip@chromium.org,
tsepez@chromium.org, avayvod@chromium.org, clamy@chromium.org
Link to the patchset: https://codereview.chromium.org/2338223003/#ps80001
(title: "fixed tests")

[commit-bot: I haz the power, 2016-09-22 18:02:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:12:36]

Description was changed from

==========
Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

This is part of a greater effort of making MediaSession API
implementation in sync with the spec.
https://docs.google.com/a/google.com/document/d/1RNaWRpEDCGfDI5HEmMYxqA2QaD2e...

BUG=646906
==========

to

==========
Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

This is part of a greater effort of making MediaSession API
implementation in sync with the spec.
https://docs.google.com/a/google.com/document/d/1RNaWRpEDCGfDI5HEmMYxqA2QaD2e...

BUG=646906
==========

[commit-bot: I haz the power, 2016-09-22 19:12:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-22 19:15:26]

Description was changed from

==========
Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

This is part of a greater effort of making MediaSession API
implementation in sync with the spec.
https://docs.google.com/a/google.com/document/d/1RNaWRpEDCGfDI5HEmMYxqA2QaD2e...

BUG=646906
==========

to

==========
Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

This is part of a greater effort of making MediaSession API
implementation in sync with the spec.
https://docs.google.com/a/google.com/document/d/1RNaWRpEDCGfDI5HEmMYxqA2QaD2e...

BUG=646906

Committed: https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147
Cr-Commit-Position: refs/heads/master@{#420418}
==========

[commit-bot: I haz the power, 2016-09-22 19:15:28]

Patchset 5 (id:??) landed as
https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147
Cr-Commit-Position: refs/heads/master@{#420418}