Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2338223003: Unassociating MediaSession from media players (in blink & content) (Closed)
Patch Set: fixed tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | media/base/android/media_player_android.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 2607 matching lines...) Expand 10 before | Expand all | Expand 10 after
2618 #else 2618 #else
2619 return NULL; 2619 return NULL;
2620 #endif // defined(ENABLE_PLUGINS) 2620 #endif // defined(ENABLE_PLUGINS)
2621 } 2621 }
2622 2622
2623 blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer( 2623 blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
2624 const blink::WebMediaPlayerSource& source, 2624 const blink::WebMediaPlayerSource& source,
2625 WebMediaPlayerClient* client, 2625 WebMediaPlayerClient* client,
2626 WebMediaPlayerEncryptedMediaClient* encrypted_client, 2626 WebMediaPlayerEncryptedMediaClient* encrypted_client,
2627 WebContentDecryptionModule* initial_cdm, 2627 WebContentDecryptionModule* initial_cdm,
2628 const blink::WebString& sink_id, 2628 const blink::WebString& sink_id) {
2629 WebMediaSession* media_session) {
2630 blink::WebMediaStream web_stream = 2629 blink::WebMediaStream web_stream =
2631 GetWebMediaStreamFromWebMediaPlayerSource(source); 2630 GetWebMediaStreamFromWebMediaPlayerSource(source);
2632 if (!web_stream.isNull()) 2631 if (!web_stream.isNull())
2633 return CreateWebMediaPlayerForMediaStream(client, sink_id, 2632 return CreateWebMediaPlayerForMediaStream(client, sink_id,
2634 frame_->getSecurityOrigin()); 2633 frame_->getSecurityOrigin());
2635 2634
2636 // If |source| was not a MediaStream, it must be a URL. 2635 // If |source| was not a MediaStream, it must be a URL.
2637 // TODO(guidou): Fix this when support for other srcObject types is added. 2636 // TODO(guidou): Fix this when support for other srcObject types is added.
2638 DCHECK(source.isURL()); 2637 DCHECK(source.isURL());
2639 blink::WebURL url = source.getAsURL(); 2638 blink::WebURL url = source.getAsURL();
(...skipping 23 matching lines...) Expand all
2663 media::WebMediaPlayerParams params( 2662 media::WebMediaPlayerParams params(
2664 base::Bind(&ContentRendererClient::DeferMediaLoad, 2663 base::Bind(&ContentRendererClient::DeferMediaLoad,
2665 base::Unretained(GetContentClient()->renderer()), 2664 base::Unretained(GetContentClient()->renderer()),
2666 static_cast<RenderFrame*>(this), 2665 static_cast<RenderFrame*>(this),
2667 GetWebMediaPlayerDelegate()->has_played_media()), 2666 GetWebMediaPlayerDelegate()->has_played_media()),
2668 audio_renderer_sink, media_log, render_thread->GetMediaThreadTaskRunner(), 2667 audio_renderer_sink, media_log, render_thread->GetMediaThreadTaskRunner(),
2669 render_thread->GetWorkerTaskRunner(), 2668 render_thread->GetWorkerTaskRunner(),
2670 render_thread->compositor_task_runner(), context_3d_cb, 2669 render_thread->compositor_task_runner(), context_3d_cb,
2671 base::Bind(&v8::Isolate::AdjustAmountOfExternalAllocatedMemory, 2670 base::Bind(&v8::Isolate::AdjustAmountOfExternalAllocatedMemory,
2672 base::Unretained(blink::mainThreadIsolate())), 2671 base::Unretained(blink::mainThreadIsolate())),
2673 initial_cdm, media_surface_manager_, media_session); 2672 initial_cdm, media_surface_manager_);
2674 2673
2675 #if defined(OS_ANDROID) 2674 #if defined(OS_ANDROID)
2676 if (!UseWebMediaPlayerImpl(url)) { 2675 if (!UseWebMediaPlayerImpl(url)) {
2677 return CreateAndroidWebMediaPlayer(client, encrypted_client, params); 2676 return CreateAndroidWebMediaPlayer(client, encrypted_client, params);
2678 } 2677 }
2679 #endif // defined(OS_ANDROID) 2678 #endif // defined(OS_ANDROID)
2680 2679
2681 #if defined(ENABLE_MOJO_RENDERER) 2680 #if defined(ENABLE_MOJO_RENDERER)
2682 std::unique_ptr<media::RendererFactory> media_renderer_factory( 2681 std::unique_ptr<media::RendererFactory> media_renderer_factory(
2683 new media::MojoRendererFactory( 2682 new media::MojoRendererFactory(
(...skipping 3707 matching lines...) Expand 10 before | Expand all | Expand 10 after
6391 // event target. Potentially a Pepper plugin will receive the event. 6390 // event target. Potentially a Pepper plugin will receive the event.
6392 // In order to tell whether a plugin gets the last mouse event and which it 6391 // In order to tell whether a plugin gets the last mouse event and which it
6393 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6392 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6394 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6393 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6395 // |pepper_last_mouse_event_target_|. 6394 // |pepper_last_mouse_event_target_|.
6396 pepper_last_mouse_event_target_ = nullptr; 6395 pepper_last_mouse_event_target_ = nullptr;
6397 #endif 6396 #endif
6398 } 6397 }
6399 6398
6400 } // namespace content 6399 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | media/base/android/media_player_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698