Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2338213007: Adding JS and C++ handlers for events on new Welcome page. (Closed)

Created:
4 years, 3 months ago by tmartino
Modified:
4 years, 2 months ago
Reviewers:
anthonyvd, michaelpg
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding JS and C++ handlers for events on new Welcome page. BUG=618454 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0 Cr-Commit-Position: refs/heads/master@{#421385}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Responding to anthonyvd comments #

Patch Set 3 : Further comments from anthonyvd #

Total comments: 17

Patch Set 4 : Addressing michaelpg feedback #

Patch Set 5 : Correcting broken include #

Patch Set 6 : Forward Declarations #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -18 lines) Patch
M chrome/browser/resources/welcome/welcome.html View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/welcome/welcome.js View 1 2 3 1 chunk +22 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/welcome_handler.h View 1 2 3 4 5 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/welcome_handler.cc View 1 2 3 4 5 1 chunk +75 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/welcome_ui.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/welcome_ui.cc View 1 2 3 2 chunks +16 lines, -12 lines 1 comment Download

Messages

Total messages: 25 (10 generated)
tmartino
4 years, 3 months ago (2016-09-16 15:12:01 UTC) #3
anthonyvd
Sorry this took a few days, here are some initial comments! https://codereview.chromium.org/2338213007/diff/1/chrome/browser/resources/welcome/welcome.html File chrome/browser/resources/welcome/welcome.html (right): ...
4 years, 3 months ago (2016-09-19 17:12:16 UTC) #4
tmartino
Thanks! Fixed all the comments except where I've responded. https://codereview.chromium.org/2338213007/diff/1/chrome/browser/ui/webui/welcome_ui.cc File chrome/browser/ui/webui/welcome_ui.cc (right): https://codereview.chromium.org/2338213007/diff/1/chrome/browser/ui/webui/welcome_ui.cc#newcode39 chrome/browser/ui/webui/welcome_ui.cc:39: ...
4 years, 3 months ago (2016-09-19 22:37:05 UTC) #5
anthonyvd
https://codereview.chromium.org/2338213007/diff/1/chrome/browser/ui/webui/welcome_ui.cc File chrome/browser/ui/webui/welcome_ui.cc (right): https://codereview.chromium.org/2338213007/diff/1/chrome/browser/ui/webui/welcome_ui.cc#newcode39 chrome/browser/ui/webui/welcome_ui.cc:39: const char* kEverywhereVariantPath = "/1"; On 2016/09/19 22:37:04, tmartino ...
4 years, 3 months ago (2016-09-21 16:17:56 UTC) #6
tmartino
https://codereview.chromium.org/2338213007/diff/1/chrome/browser/ui/webui/welcome_ui.cc File chrome/browser/ui/webui/welcome_ui.cc (right): https://codereview.chromium.org/2338213007/diff/1/chrome/browser/ui/webui/welcome_ui.cc#newcode39 chrome/browser/ui/webui/welcome_ui.cc:39: const char* kEverywhereVariantPath = "/1"; On 2016/09/21 at 16:17:56, ...
4 years, 3 months ago (2016-09-22 20:32:09 UTC) #7
anthonyvd
lgtm, you should be good to loop in owners :)
4 years, 3 months ago (2016-09-23 16:55:52 UTC) #8
tmartino
+michaelpg for OWNERS. This is the dramatic conclusion of the UI from the last CL ...
4 years, 3 months ago (2016-09-23 17:04:49 UTC) #10
michaelpg
https://codereview.chromium.org/2338213007/diff/40001/chrome/browser/resources/welcome/welcome.html File chrome/browser/resources/welcome/welcome.html (right): https://codereview.chromium.org/2338213007/diff/40001/chrome/browser/resources/welcome/welcome.html#newcode13 chrome/browser/resources/welcome/welcome.html:13: <script src="chrome://resources/js/cr.js"></script> I suggest changing these to <link rel="import" ...
4 years, 3 months ago (2016-09-23 18:46:36 UTC) #11
tmartino
Thanks, Michael! Acted on all feedback except the forward declarations, commented below. https://codereview.chromium.org/2338213007/diff/40001/chrome/browser/ui/webui/welcome_handler.cc File chrome/browser/ui/webui/welcome_handler.cc ...
4 years, 2 months ago (2016-09-26 23:10:15 UTC) #12
tmartino
https://codereview.chromium.org/2338213007/diff/40001/chrome/browser/ui/webui/welcome_handler.h File chrome/browser/ui/webui/welcome_handler.h (right): https://codereview.chromium.org/2338213007/diff/40001/chrome/browser/ui/webui/welcome_handler.h#newcode8 chrome/browser/ui/webui/welcome_handler.h:8: #include "chrome/browser/profiles/profile.h" On 2016/09/26 at 23:10:15, tmartino wrote: > ...
4 years, 2 months ago (2016-09-27 15:43:24 UTC) #13
michaelpg
lgtm https://codereview.chromium.org/2338213007/diff/100001/chrome/browser/ui/webui/welcome_ui.cc File chrome/browser/ui/webui/welcome_ui.cc (right): https://codereview.chromium.org/2338213007/diff/100001/chrome/browser/ui/webui/welcome_ui.cc#newcode23 chrome/browser/ui/webui/welcome_ui.cc:23: // here, we return, causing a 404-like page. ...
4 years, 2 months ago (2016-09-27 21:14:12 UTC) #14
tmartino
On 2016/09/27 at 21:14:12, michaelpg wrote: > lgtm > > https://codereview.chromium.org/2338213007/diff/100001/chrome/browser/ui/webui/welcome_ui.cc > File chrome/browser/ui/webui/welcome_ui.cc (right): ...
4 years, 2 months ago (2016-09-27 22:27:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338213007/100001
4 years, 2 months ago (2016-09-27 23:34:04 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-09-27 23:39:39 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 23:41:36 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0
Cr-Commit-Position: refs/heads/master@{#421385}

Powered by Google App Engine
This is Rietveld 408576698