chrome/browser/resources/welcome/welcome.html - Issue 2338213007: Adding JS and C++ handlers for events on new Welcome page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/welcome/welcome.html

Issue 2338213007: Adding JS and C++ handlers for events on new Welcome page. (Closed)

Patch Set: Further comments from anthonyvd Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>$i18n{headerText}</title>	4 <title>$i18n{headerText}</title>

5	5

6 <link rel="import" href="chrome://resources/html/polymer.html">	6 <link rel="import" href="chrome://resources/html/polymer.html">

7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-bu tton.html">	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-bu tton.html">

8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.ht ml">	8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.ht ml">

9	9

10 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	10 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

11 <link rel="stylesheet" href="chrome://welcome/welcome.css">	11 <link rel="stylesheet" href="chrome://welcome/welcome.css">

12	12

	13 <script src="chrome://resources/js/cr.js"></script>
	michaelpg 2016/09/23 18:46:35 I suggest changing these to <link rel="import" ... I suggest changing these to <link rel="import" ...> for the equivalent HTML files. HTML imports make dependency management a lot easier, prevent duplicate imports, etc.
13 <script src="chrome://resources/js/load_time_data.js"></script>	14 <script src="chrome://resources/js/load_time_data.js"></script>
	michaelpg 2016/09/23 18:46:35 unused? unused?
	15 <script src="chrome://resources/js/util.js"></script>

14 <script src="chrome://welcome/welcome.js"></script>	16 <script src="chrome://welcome/welcome.js"></script>

15	17

16 </head>	18 </head>

17 <body>	19 <body>

18 <div class="spacer"></div>	20 <div class="spacer"></div>

19 <div class="content">	21 <div class="content">

20 <div class="logo">	22 <div class="logo">

21 <div class="logo-icon">	23 <div class="logo-icon">

22 <img src="chrome://welcome/logo.png" class="logo-bw">	24 <img src="chrome://welcome/logo.png" class="logo-bw">

23 <img src="chrome://welcome/logo.png" class="logo-color">	25 <img src="chrome://welcome/logo.png" class="logo-color">

24 </div>	26 </div>

25 <div class="logo-shadow"></div>	27 <div class="logo-shadow"></div>

26 </div>	28 </div>

27 <div class="heading">$i18n{headerText}</div>	29 <div class="heading">$i18n{headerText}</div>

28 <if expr="_google_chrome">	30 <if expr="_google_chrome">

29 <div class="subheading">$i18n{subheaderText}</div>	31 <div class="subheading">$i18n{subheaderText}</div>

30 </if>	32 </if>

31 <div class="signin">	33 <div class="signin">

32 <div class="signin-description">$i18n{descriptionText}</div>	34 <div class="signin-description">$i18n{descriptionText}</div>

33 <div class="signin-buttons">	35 <div class="signin-buttons">

34 <paper-button class="action">$i18n{acceptText}</paper-button>	36 <paper-button class="action" id="accept-button">$i18n{acceptText}</paper -button>

35 <a href="#" class="link">$i18n{declineText}</a>	37 <a href="#" class="link" id="decline-button">$i18n{declineText}</a>

36 </div>	38 </div>

37 </div>	39 </div>

38 </div>	40 </div>

39 <div class="watermark"></div>	41 <div class="watermark"></div>

40 </body>	42 </body>

41 </html>	43 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/resources/welcome/welcome.js » ('j') | chrome/browser/resources/welcome/welcome.js » ('J')