Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h

Issue 2338173005: [Blink, RemotePlayback] Dismissing the dialog rejects with NotAllowedError. (Closed)
Patch Set: Fixed base class exports for WIN build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
index cc287ed5294870c2b4a12bbf1a7aa4a7027586c5..acd831d70c142fb27accac3623dde17cc0fa1e6d 100644
--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
@@ -8,6 +8,7 @@
#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "core/events/EventTarget.h"
+#include "modules/ModulesExport.h"
#include "platform/heap/Handle.h"
#include "public/platform/modules/remoteplayback/WebRemotePlaybackClient.h"
#include "public/platform/modules/remoteplayback/WebRemotePlaybackState.h"
@@ -22,9 +23,9 @@ class LocalFrame;
class RemotePlaybackAvailability;
class ScriptPromiseResolver;
-class RemotePlayback final : public EventTargetWithInlineData,
- public ActiveScriptWrappable,
- private WebRemotePlaybackClient {
+class MODULES_EXPORT RemotePlayback final : public EventTargetWithInlineData,
+ public ActiveScriptWrappable,
+ private WebRemotePlaybackClient {
mlamouri (slow - plz ping) 2016/10/06 10:55:08 should you do `NON_EXPORTED_BASE(WebRemotePlayback
whywhat 2016/10/06 18:18:48 I should probably :P
DEFINE_WRAPPERTYPEINFO();
USING_GARBAGE_COLLECTED_MIXIN(RemotePlayback);
@@ -48,6 +49,8 @@ class RemotePlayback final : public EventTargetWithInlineData,
DECLARE_VIRTUAL_TRACE();
private:
+ friend class RemotePlaybackTest;
+
explicit RemotePlayback(HTMLMediaElement&);
// WebRemotePlaybackClient implementation.

Powered by Google App Engine
This is Rietveld 408576698