third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h - Issue 2338173005: [Blink, RemotePlayback] Dismissing the dialog rejects with NotAllowedError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h

Issue 2338173005: [Blink, RemotePlayback] Dismissing the dialog rejects with NotAllowedError. (Closed)

Patch Set: Fixed base class exports for WIN build Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h ('K') | « third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h

diff --git a/third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h b/third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h

index 6131d9eb2a93b6c9c915efd8757b43d3a9805d9d..78881c5b853e8b94e029f74eed740dfecd4aaffd 100644

--- a/third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h

+++ b/third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h

@@ -5,13 +5,15 @@

#ifndef WebRemotePlaybackClient_h

#define WebRemotePlaybackClient_h

+#include "public/platform/WebCommon.h"

namespace blink {

enum class WebRemotePlaybackState;

// The interface between the HTMLMediaElement and its

// HTMLMediaElementRemotePlayback supplement.

-class WebRemotePlaybackClient {

+class BLINK_PLATFORM_EXPORT WebRemotePlaybackClient {

mlamouri (slow - plz ping) 2016/10/06 10:55:38 Just saw that you did this. Why exporting somethin

whywhat 2016/10/06 18:18:48 Because I didn't remember NON_EXPORTED_BASE ?

public:

virtual ~WebRemotePlaybackClient() = default;