third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp - Issue 2338173005: [Blink, RemotePlayback] Dismissing the dialog rejects with NotAllowedError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

Issue 2338173005: [Blink, RemotePlayback] Dismissing the dialog rejects with NotAllowedError. (Closed)

Patch Set: Fixed base class exports for WIN build Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h ('K') | « third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h ('k') | third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp » ('j') | third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

index 254970a103d39f9cdb172443ca67a38a4bbf04e7..13088b1eea0a7be80f670070964fdada15c0d948 100644

--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

@@ -161,7 +161,8 @@ void RemotePlayback::promptCancelled() {

if (!m_promptPromiseResolver)

return;

- m_promptPromiseResolver->resolve();

+ m_promptPromiseResolver->reject(

+ DOMException::create(NotAllowedError, "The prompt was dismissed."));

m_promptPromiseResolver = nullptr;

}