Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2338163003: Revert of Fix webkit_tests by adding two more interfaces they expect. (Closed)

Created:
4 years, 3 months ago by msw
Modified:
4 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix webkit_tests by adding two more interfaces they expect. (patchset #1 id:1 of https://codereview.chromium.org/2339703003/ ) Reason for revert: Reverting this and https://codereview.chromium.org/2259903002 I'll post more details on the other CL Original issue's description: > Fix webkit_tests by adding two more interfaces they expect. > > TBR=rockot@chromium.org,tsepez@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/5a3bcc8be6b98f0084ad3cbf45045cfa4f848e3c > Cr-Commit-Position: refs/heads/master@{#418600} TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e05c5726be5bbfb74adda70843d0e823ba2ed1b5 Cr-Commit-Position: refs/heads/master@{#418612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
msw
Created Revert of Fix webkit_tests by adding two more interfaces they expect.
4 years, 3 months ago (2016-09-14 18:14:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338163003/1
4 years, 3 months ago (2016-09-14 18:15:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 18:16:11 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:19:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e05c5726be5bbfb74adda70843d0e823ba2ed1b5
Cr-Commit-Position: refs/heads/master@{#418612}

Powered by Google App Engine
This is Rietveld 408576698