[NTP] Fix article suggestion clicks contributing to Most Visited tiles

components/history/core/browser/history_types.h

Index: components/history/core/browser/history_types.h
diff --git a/components/history/core/browser/history_types.h b/components/history/core/browser/history_types.h
index 9795ded30ae0f6bf2100568f573a5c819f5d6fab..2d68bbc365bb3aced405088c038cd0d7ce036b73 100644
--- a/components/history/core/browser/history_types.h
+++ b/components/history/core/browser/history_types.h
@@ -332,7 +332,7 @@ struct MostVisitedURL {
 
   RedirectList redirects;
 
-  bool operator==(const MostVisitedURL& other) {
+  bool operator==(const MostVisitedURL& other) const {
     return url == other.url;
   }
 };
@@ -372,7 +372,7 @@ struct HistoryAddPageArgs {
   //   HistoryAddPageArgs(
   //       GURL(), base::Time(), NULL, 0, GURL(),
   //       RedirectList(), ui::PAGE_TRANSITION_LINK,
-  //       SOURCE_BROWSED, false)
+  //       SOURCE_BROWSED, false, false)
   HistoryAddPageArgs();
   HistoryAddPageArgs(const GURL& url,
                      base::Time time,
@@ -382,7 +382,8 @@ struct HistoryAddPageArgs {
                      const RedirectList& redirects,
                      ui::PageTransition transition,
                      VisitSource source,
-                     bool did_replace_entry);
+                     bool did_replace_entry,
+                     bool skip_for_ntp_most_visited);

[sky, 2016/09/15 22:56:10]

Variables with negative names in them are harder to understand. Please use
something like include_in_ntp_most_visited. You can also use a default value for
it if you want. Lastly, make the parameter here match the name of the field.

[mastiz, 2016/09/16 08:42:10]

Done. I avoided the default value for consistency.

FYI, the reason why I negated the logic was to keep 'false' as default value,
which I liked in case the code evolves to use C++11 list initialization.

Besides, to double check, as mentioned in my previous reply, note that I didn't
extend the signature of AddPage() for the overload with all inlined args (would
require updating many clients).

   HistoryAddPageArgs(const HistoryAddPageArgs& other);
   ~HistoryAddPageArgs();
 
@@ -395,6 +396,7 @@ struct HistoryAddPageArgs {
   ui::PageTransition transition;
   VisitSource visit_source;
   bool did_replace_entry;
+  bool ignore_for_ntp_most_visited;
 };
 
 // TopSites -------------------------------------------------------------------