[NTP] Fix article suggestion clicks contributing to Most Visited tiles

components/history/core/browser/history_types.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_TYPES_H_
 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_TYPES_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 314 matching lines @@
   GURL url;
   base::string16 title;
 
   // If this is a URL for which we want to force a thumbnail, records the last
   // time it was forced so we can evict it when more recent URLs are requested.
   // If it's not a forced thumbnail, keep a time of 0.
   base::Time last_forced_time;
 
   RedirectList redirects;
 
-  bool operator==(const MostVisitedURL& other) {
+  bool operator==(const MostVisitedURL& other) const {
     return url == other.url;
   }
 };
 
 // FilteredURL -----------------------------------------------------------------
 
 // Holds the per-URL information of the filterd url query.
 struct FilteredURL {
   struct ExtendedInfo {
     ExtendedInfo();
@@ skipping 19 matching lines @@
 
 // Navigation -----------------------------------------------------------------
 
 // Marshalling structure for AddPage.
 struct HistoryAddPageArgs {
   // The default constructor is equivalent to:
   //
   //   HistoryAddPageArgs(
   //       GURL(), base::Time(), NULL, 0, GURL(),
   //       RedirectList(), ui::PAGE_TRANSITION_LINK,
-  //       SOURCE_BROWSED, false)
+  //       SOURCE_BROWSED, false, false)
   HistoryAddPageArgs();
   HistoryAddPageArgs(const GURL& url,
                      base::Time time,
                      ContextID context_id,
                      int nav_entry_id,
                      const GURL& referrer,
                      const RedirectList& redirects,
                      ui::PageTransition transition,
                      VisitSource source,
-                     bool did_replace_entry);
+                     bool did_replace_entry,
+                     bool skip_for_ntp_most_visited);

[sky, 2016/09/15 22:56:10]

Variables with negative names in them are harder to understand. Please use
something like include_in_ntp_most_visited. You can also use a default value for
it if you want. Lastly, make the parameter here match the name of the field.

[mastiz, 2016/09/16 08:42:10]

Done. I avoided the default value for consistency.

FYI, the reason why I negated the logic was to keep 'false' as default value,
which I liked in case the code evolves to use C++11 list initialization.

Besides, to double check, as mentioned in my previous reply, note that I didn't
extend the signature of AddPage() for the overload with all inlined args (would
require updating many clients).

   HistoryAddPageArgs(const HistoryAddPageArgs& other);
   ~HistoryAddPageArgs();
 
   GURL url;
   base::Time time;
   ContextID context_id;
   int nav_entry_id;
   GURL referrer;
   RedirectList redirects;
   ui::PageTransition transition;
   VisitSource visit_source;
   bool did_replace_entry;
+  bool ignore_for_ntp_most_visited;
 };
 
 // TopSites -------------------------------------------------------------------
 
 typedef std::vector<MostVisitedURL> MostVisitedURLList;
 typedef std::vector<FilteredURL> FilteredURLList;
 
 // Used by TopSites to store the thumbnails.
 struct Images {
   Images();
@@ skipping 140 matching lines @@
   void SetTimeRangeForOneDay(base::Time time);
 
   std::set<GURL> urls;
   base::Time begin_time;
   base::Time end_time;
 };
 
 }  // namespace history
 
 #endif  // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_TYPES_H_