exo: Report tool type with pointer enter event

exo: Report tool type with pointer enter event

This change updates the behavior when switching tool types. The tool
type is always sent with the pointer enter event, and when the type
switches while an exo surface is in focus, we will leave and re-enter
the surface with the new tool type.

BUG=645576
Committed: https://crrev.com/b31cb3833244ed1c62776b7fe080f1da7f387f85
Cr-Commit-Position: refs/heads/master@{#418928}

[denniskempin, 2016-09-14 17:39:50]

denniskempin@google.com changed reviewers:
+ reveman@chromium.org

[reveman, 2016-09-14 18:59:33]

why do we need to leave and re-enter when we have an event for notifying that
the tool type changed?

[denniskempin, 2016-09-14 20:06:10]

On 2016/09/14 18:59:33, reveman wrote:
> why do we need to leave and re-enter when we have an event for notifying that
> the tool type changed?

I think this will be easier to handle for the client. 

For clients without support for pen, they will see the cursor leaving and
re-appearing somewhere else. Instead of potentially making a big jump in
movement when switching the tool. 

Android devices and the web APIs do handle it in a similar way. 

Alternatively to this, we could keep the original behavior and make sure to
report the pointer type as well when entering the surface.
Before the sequence was:
Enter
Frame
ToolChange
Frame

But we need it to be sent in the same frame. 

Let me know which way you'd prefer to go.

[reveman, 2016-09-14 21:30:48]

On 2016/09/14 at 20:06:10, denniskempin wrote:
> On 2016/09/14 18:59:33, reveman wrote:
> > why do we need to leave and re-enter when we have an event for notifying
that
> > the tool type changed?
> 
> I think this will be easier to handle for the client. 
> 
> For clients without support for pen, they will see the cursor leaving and
re-appearing somewhere else. Instead of potentially making a big jump in
movement when switching the tool. 
> 

It could be confusing to a client to receive leave/enter without pointer
actually entering a different surface. 

> 
> Android devices and the web APIs do handle it in a similar way. 
> 
> Alternatively to this, we could keep the original behavior and make sure to
report the pointer type as well when entering the surface.
> Before the sequence was:
> Enter
> Frame
> ToolChange
> Frame
> 
> But we need it to be sent in the same frame. 
> 
> Let me know which way you'd prefer to go.

I think it would be nice to include the Tool event in the same frame as the
Enter event. I like that approach better unless there's something that makes
that complicated.

[chromium-reviews, 2016-09-14 21:46:16]

nothing really. will do :)

On Wed, Sep 14, 2016 at 2:30 PM <reveman@chromium.org> wrote:

> On 2016/09/14 at 20:06:10, denniskempin wrote:
> > On 2016/09/14 18:59:33, reveman wrote:
> > > why do we need to leave and re-enter when we have an event for
> notifying
> that
> > > the tool type changed?
> >
> > I think this will be easier to handle for the client.
> >
> > For clients without support for pen, they will see the cursor leaving and
> re-appearing somewhere else. Instead of potentially making a big jump in
> movement when switching the tool.
> >
>
> It could be confusing to a client to receive leave/enter without pointer
> actually entering a different surface.
>
> >
> > Android devices and the web APIs do handle it in a similar way.
> >
> > Alternatively to this, we could keep the original behavior and make sure
> to
> report the pointer type as well when entering the surface.
> > Before the sequence was:
> > Enter
> > Frame
> > ToolChange
> > Frame
> >
> > But we need it to be sent in the same frame.
> >
> > Let me know which way you'd prefer to go.
>
> I think it would be nice to include the Tool event in the same frame as the
> Enter event. I like that approach better unless there's something that
> makes
> that complicated.
>
> https://codereview.chromium.org/2338133004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[denniskempin, 2016-09-14 23:31:30]

Done. PTAL

[reveman, 2016-09-15 01:19:26]

lgtm

[denniskempin, 2016-09-15 18:24:32]

The CQ bit was checked by denniskempin@google.com

[commit-bot: I haz the power, 2016-09-15 18:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 19:06:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 19:10:04]

Description was changed from

==========
exo: Report tool type with pointer enter event

This change updates the behavior when switching tool types. The tool
type is always sent with the pointer enter event, and when the type
switches while an exo surface is in focus, we will leave and re-enter
the surface with the new tool type.

BUG=645576
==========

to

==========
exo: Report tool type with pointer enter event

This change updates the behavior when switching tool types. The tool
type is always sent with the pointer enter event, and when the type
switches while an exo surface is in focus, we will leave and re-enter
the surface with the new tool type.

BUG=645576

Committed: https://crrev.com/b31cb3833244ed1c62776b7fe080f1da7f387f85
Cr-Commit-Position: refs/heads/master@{#418928}
==========

[commit-bot: I haz the power, 2016-09-15 19:10:05]

Patchset 2 (id:??) landed as
https://crrev.com/b31cb3833244ed1c62776b7fe080f1da7f387f85
Cr-Commit-Position: refs/heads/master@{#418928}