exo: Send pointer location before button event

exo: Send pointer location before button event

We are not guranteed a mouse motion event before receiving a button
event, which can lead to clicks at the wrong location.
This CL makes sure that button events will report any location and
pointer changes before generating the button event.

BUG=645576
Committed: https://crrev.com/89504256241c40140c4dcfea06c3a24bf5007d74
Cr-Commit-Position: refs/heads/master@{#419596}

[denniskempin, 2016-09-16 16:58:55]

denniskempin@google.com changed reviewers:
+ reveman@chromium.org

[denniskempin, 2016-09-16 16:58:55]

PTAL David! Checked with input folks, we are not guaranteed a motion event
before button events at a new location.

[reveman, 2016-09-16 17:11:26]

https://codereview.chromium.org/2342413002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2342413002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:258: }
I'm failing to see how this change makes any difference. How is this making use
send the location change event before button press/release events?

[reveman, 2016-09-16 17:36:30]

lgtm + nit

https://codereview.chromium.org/2342413002/diff/20001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2342413002/diff/20001/components/exo/pointer....
components/exo/pointer.cc:205: delegate_->OnPointerFrame();
nit: can we delay this until after the switch statement and avoid sending
multiple frame events?

[denniskempin, 2016-09-16 17:54:25]

The CQ bit was checked by denniskempin@google.com

[commit-bot: I haz the power, 2016-09-16 17:54:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:58:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 18:58:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[denniskempin, 2016-09-19 22:20:07]

The CQ bit was checked by denniskempin@google.com

[denniskempin, 2016-09-19 22:20:08]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2342413002/#ps40001
(title: "do not update location on events that do not contain location")

[commit-bot: I haz the power, 2016-09-19 22:20:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 22:43:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-19 22:45:07]

Description was changed from

==========
exo: Send pointer location before button event

We are not guranteed a mouse motion event before receiving a button
event, which can lead to clicks at the wrong location.
This CL makes sure that button events will report any location and
pointer changes before generating the button event.

BUG=645576
==========

to

==========
exo: Send pointer location before button event

We are not guranteed a mouse motion event before receiving a button
event, which can lead to clicks at the wrong location.
This CL makes sure that button events will report any location and
pointer changes before generating the button event.

BUG=645576

Committed: https://crrev.com/89504256241c40140c4dcfea06c3a24bf5007d74
Cr-Commit-Position: refs/heads/master@{#419596}
==========

[commit-bot: I haz the power, 2016-09-19 22:45:08]

Patchset 3 (id:??) landed as
https://crrev.com/89504256241c40140c4dcfea06c3a24bf5007d74
Cr-Commit-Position: refs/heads/master@{#419596}