Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2338113002: Revert "Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (Closed)

Created:
4 years, 3 months ago by falken
Modified:
4 years, 3 months ago
Reviewers:
jam, horo
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://codereview.chromium.org/2254963002/ )" This reverts commit d1109b15f8669b2c342d87e9ae6e5d8ebd669ada. The crash rate is too high and polluting crash report data. I'll reland it when the fix lands. BUG=636377 TBR=jam Committed: https://crrev.com/2639679013cd3c2bbf7603cd805a0ba3641f7055 Cr-Commit-Position: refs/heads/master@{#418462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
falken
4 years, 3 months ago (2016-09-13 23:58:48 UTC) #2
falken
4 years, 3 months ago (2016-09-14 00:03:37 UTC) #4
horo
lgtm
4 years, 3 months ago (2016-09-14 00:41:27 UTC) #5
falken
Thanks. TBR=jam as this is a revert.
4 years, 3 months ago (2016-09-14 00:44:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338113002/1
4 years, 3 months ago (2016-09-14 00:44:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 02:50:23 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2639679013cd3c2bbf7603cd805a0ba3641f7055 Cr-Commit-Position: refs/heads/master@{#418462}
4 years, 3 months ago (2016-09-14 02:52:22 UTC) #13
falken
4 years, 2 months ago (2016-09-24 15:30:08 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2364113003/ by falken@chromium.org.

The reason for reverting is: Relanding after the attempted fix in
https://crrev.com/04a6912a1a2b77faf61e4b2514b9ecff74ee1f21.

Powered by Google App Engine
This is Rietveld 408576698